fix: 🐛 PDF Filter Type Error #27154
Merged
fix: 🐛 PDF Filter Type Error #27154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
efriis
reviewed
Dec 13, 2024
| else: | ||
| filter_names = [img_filter.name] | ||
|
|
||
| if any(name in _PDF_FILTER_WITHOUT_LOSS for name in filter_names): |
There was a problem hiding this comment.
if both are passed, should we throw an error that only one or the other should be passed?
dosubot
bot
added
size:M
efriis
approved these changes
Dec 13, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
PR title: "community: fix PDF Filter Type Error"
Description: fix PDF Filter Type Error"
Issue: the issue PDFMinerParser Bug: Failed to Recognize Filter Type Error #27153 it fixes,
Dependencies: no
Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!
Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.