Repository navigation
chore(langsmith): drop the langsmith-clio image - #910
Merged
Merged
Conversation
Enabling Engine took two settings that had to agree: engine.enabled, and an images.engineInsightsAgentImage.repository pointing at the combined image, since the default served only the insights graph. Them disagreeing is what surfaced as a chart that demanded an image customers had no way to pull. The combined image serves both graphs and is no larger — 392 MB against clio's 397 MB compressed on amd64, same architectures — so nothing is paid for defaulting to it. engine.enabled is now sufficient on its own. The validate.yaml guard stays: an install that pinned langsmith-clio in its own values keeps that pin across the upgrade, and the guard is what tells it why Engine will not start. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Insights and Engine run on the combined langsmith-insights-engine image, so clio is no longer a supported value for images.engineInsightsAgentImage. The image guard moves out of the engine.enabled block and applies to every install. It now also matches on the tag, because the marketplace packaging rewrites every image to one shared repo and moves the name into the tag -- a repository-only check would reject those installs. Also fixes the marketplace scripts, which still carried clio and had no entry for the combined image: push_helm_chart.sh left engineInsightsAgentImage pointing at docker.io instead of the marketplace ECR, and create_marketplace_version.sh never listed it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The combined image exposes `insights` and `engine`; only the retired clio image had the `agent` graph that lc_config still defaults to. Defaulting every install to the combined image therefore left installs with engine.enabled=false pointing smith-backend at a graph that does not exist, breaking Insights wherever Engine is not turned on. CLIO_ASSISTANT_ID follows the image, so it moves out of the engine.enabled block. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Base automatically changed from
chore/default-insights-engine-image
to
v16-stable
August 4, 2026 22:05
Mukil Loganathan (langchain-infra)
approved these changes
Aug 4, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bagatur (baskaryan)
enabled auto-merge (squash)
August 4, 2026 22:38
This was referenced Aug 5, 2026
Bagatur (baskaryan)
added a commit
that referenced
this pull request
Aug 19, 2026
* feat(engine): bring Engine/Insights chart support to main The Engine work landed on v16-stable and was never forward-ported, so main has no Engine support at all and still ships langsmith-clio as the insights image. v17 would ship without Engine. Ports the Insights/Engine parts of #889, #893, #896, #897, #898, #900, #901, #909, #910 and #914: the co-hosted deployment on the combined image, the engine values block and its validate guards, Engine env for the co-host and for smith-go, the kill-switch when Engine is off, and the image rename across the insights templates and packaging scripts. Reconstructed against main rather than cherry-picked. The branches have diverged in both directions, so replaying commits would have dragged v16's older image tags and superseded comments back over main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(engine): trim the engine values comments The README's Engine section carries the requirements and the workspace guidance, so the value comments only need a line each. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #909 — retarget to
v16-stableonce that merges.Insights and Engine run on the combined
langsmith-insights-engineimage, solangsmith-cliois no longer a supported value forimages.engineInsightsAgentImage. v16 is still on rc, so nothing has shipped with clio under the new key name.The guard
Moves out of the
engine.enabledblock so it applies to every install, and now matches on the tag as well as the repository. That second arm is load-bearing:push_helm_chart.shrewrites marketplace values so every image shares one ECR repo and the image name moves into the tag (repository: <registry>/<ns>/langsmith,tag: langsmith-insights-engine-<version>). A repository-only check would reject every marketplace install. The tag arm is anchored to thelangsmith-insights-engine-prefix rather than a loosecontainsso it can't be used to point the repository somewhere arbitrary.Installs upgrading from v15 that pinned the old
images.insightsAgentImagekey are unaffected — the existing rename guard catches them first with its own message.Marketplace scripts (pre-existing bug)
#900 added the combined image to
mirror_langsmith_images.shonly. Both marketplace scripts still carried clio and had no entry forlangsmith-insights-engine, so on the marketplace path:push_helm_chart.shleftengineInsightsAgentImagepointing atdocker.io/langchain/langsmith-insights-engine, un-rewritten — a marketplace install would pull the co-host image from Docker Hub instead of the marketplace ECR.create_marketplace_version.shnever listed the image inCONTAINER_IMAGES, so it wasn't part of the marketplace version at all.Both now reference the combined image.
Verification
helm lintclean.helm templateend to end: default renders; clio pinned fails with the new message with Engine disabled; marketplace layout (name in tag) renders.push_helm_chart.sh's actual rewrite against the realvalues.yamland confirmed the output renders against the new guard — and that the pre-change map left the image on docker.io.No
values.yamlchange, so the generated README is unaffected.Follow-ups
main— it has none of it (stillinsightsAgentImage: langsmith-clio, noengine:block, zeroengine.enabledguards). 32 chart commits onv16-stableare absent frommain, ~20 of them real fixes. As it stands v17 ships without Engine.mainno longer references clio, drop it from the promotion matrix in langchainplus so it stops being built and published.🤖 Generated with Claude Code