Repository navigation
chore(engine): make engine.sandboxTenantId optional - #896
Merged
Bagatur (baskaryan) merged 1 commit intoJul 31, 2026
Merged
Conversation
smith-go resolves the install's workspace and passes it to the agent (langchainplus #32433), so the chart no longer has to require it. That shipped in 0.16.30rc1, which this chart now points at, so the guard can go. It stays available as an override for installs that want a dedicated workspace, and for the ambiguous case: smith-go declines to guess when there is more than one non-personal org, and the agent then errors naming the setting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bagatur (baskaryan)
enabled auto-merge (squash)
July 31, 2026 12:34
Mukil Loganathan (langchain-infra)
approved these changes
Jul 31, 2026
Bagatur (baskaryan)
added a commit
that referenced
this pull request
Aug 19, 2026
* feat(engine): bring Engine/Insights chart support to main The Engine work landed on v16-stable and was never forward-ported, so main has no Engine support at all and still ships langsmith-clio as the insights image. v17 would ship without Engine. Ports the Insights/Engine parts of #889, #893, #896, #897, #898, #900, #901, #909, #910 and #914: the co-hosted deployment on the combined image, the engine values block and its validate guards, Engine env for the co-host and for smith-go, the kill-switch when Engine is off, and the image rename across the insights templates and packaging scripts. Reconstructed against main rather than cherry-picked. The branches have diverged in both directions, so replaying commits would have dragged v16's older image tags and superseded comments back over main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(engine): trim the engine values comments The README's Engine section carries the requirements and the workspace guidance, so the value comments only need a line each. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smith-go resolves the install's workspace and passes it to the agent (langchainplus #32433), so the chart no longer has to require
engine.sandboxTenantId. That shipped in0.16.30rc1, which this chart now points at, so the guard can go.This is the follow-up noted in langchainplus #32385: the guard was deliberately left in place until an image containing the resolver existed, so a deploy could not go green while runs still failed.
It stays available as an override for installs that want a dedicated workspace. smith-go declines to guess when there is more than one non-personal org, and the agent then errors naming the setting — so the failure mode is a clear message, not a wrong workspace.
Changes
failfromvalidate.yamlvalues.yamldoc from required to overrideTest Plan
helm unittest charts/langsmith— 283/283helm lintcleansandboxTenantIdWhy now
stable-dualjust had sandboxes enabled (deployments#34738) and is the first cluster running released 0.16 artifacts with the infrastructure for Engine. Leaving it unset there exercises the resolver end to end, which nothing has yet done —self-hosted-cisets the value explicitly.