Skip to content

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Jun 27, 2023

Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen Oppen force-pushed the chore/integrate_take_until_unbalanced branch from f2922f2 to ed83736 Compare June 27, 2023 18:53
@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label Jun 27, 2023
@Oppen Oppen force-pushed the chore/integrate_take_until_unbalanced branch from ed83736 to 625c669 Compare June 27, 2023 18:57
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 12.777 ± 0.264 12.420 13.154 1.00
head blake2s_integration_benchmark 12.916 ± 0.337 12.108 13.246 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.542 ± 0.108 4.345 4.635 1.00
head compare_arrays_200000 4.543 ± 0.069 4.441 4.638 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.013 ± 0.067 2.896 3.110 1.01 ± 0.03
head dict_integration_benchmark 2.996 ± 0.058 2.897 3.046 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.837 ± 0.089 4.711 4.954 1.03 ± 0.04
head factorial_multirun 4.691 ± 0.138 4.431 4.920 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.223 ± 0.034 4.179 4.300 1.01 ± 0.01
head fibonacci_1000_multirun 4.186 ± 0.028 4.131 4.224 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.128 ± 0.070 2.059 2.262 1.04 ± 0.04
head field_arithmetic_get_square_benchmark 2.053 ± 0.037 2.005 2.118 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.472 ± 0.287 10.953 11.847 1.00
head integration_builtins 11.538 ± 0.224 11.175 11.786 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 13.204 ± 0.224 12.708 13.440 1.04 ± 0.04
head keccak_integration_benchmark 12.636 ± 0.464 12.003 13.402 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.481 ± 0.162 4.174 4.656 1.00
head linear_search 4.567 ± 0.046 4.506 4.652 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.293 ± 0.047 3.186 3.327 1.05 ± 0.03
head math_cmp_and_pow_integration_benchmark 3.137 ± 0.065 3.061 3.283 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.970 ± 0.044 2.892 3.021 1.04 ± 0.03
head math_integration_benchmark 2.857 ± 0.075 2.688 2.938 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.541 ± 0.090 2.403 2.661 1.04 ± 0.04
head memory_integration_benchmark 2.434 ± 0.034 2.394 2.493 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.922 ± 0.059 2.806 3.003 1.00
head operations_with_data_structures_benchmarks 2.962 ± 0.051 2.882 3.058 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.012 ± 0.008 0.996 1.022 1.00
head pedersen 1.014 ± 0.009 0.992 1.022 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.854 ± 0.026 1.808 1.881 1.02 ± 0.02
head poseidon_integration_benchmark 1.823 ± 0.030 1.766 1.857 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.400 ± 0.094 3.161 3.484 1.00
head secp_integration_benchmark 3.546 ± 0.045 3.501 3.628 1.04 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.745 ± 0.023 1.710 1.777 1.00
head set_integration_benchmark 1.910 ± 0.039 1.838 1.952 1.09 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.105 ± 0.211 7.713 8.412 1.03 ± 0.05
head uint256_integration_benchmark 7.878 ± 0.367 7.439 8.440 1.00

Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.
@Oppen Oppen force-pushed the chore/integrate_take_until_unbalanced branch from 625c669 to 3a5b930 Compare June 27, 2023 19:38
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1287 (3a5b930) into main (f1ad334) will increase coverage by 0.00%.
The diff coverage is 99.20%.

@@           Coverage Diff            @@
##             main    #1287    +/-   ##
========================================
  Coverage   97.55%   97.56%            
========================================
  Files          90       90            
  Lines       36134    36260   +126     
========================================
+ Hits        35252    35377   +125     
- Misses        882      883     +1     
Impacted Files Coverage Δ
vm/src/serde/deserialize_utils.rs 97.04% <99.20%> (+0.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SantiagoPittella SantiagoPittella added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit 9ba3c6a Jun 27, 2023
@SantiagoPittella SantiagoPittella deleted the chore/integrate_take_until_unbalanced branch June 27, 2023 20:50
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
Since it's a single function, it's better to simplify deployment by
avoiding an extra crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines This PR/issue is exclusively about improving our CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants