Skip to content

Commit 0614d45

Browse files
Oppenkariy
authored andcommitted
chore: move take_until_unbalanced to vm/serde (lambdaclass#1287)
Since it's a single function, it's better to simplify deployment by avoiding an extra crate.
1 parent 7126947 commit 0614d45

File tree

12 files changed

+158
-295
lines changed

12 files changed

+158
-295
lines changed

.github/codecov.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@ ignore:
99
- vm/src/types/errors
1010
- hint_accountant
1111
- vm/src/hint_processor/cairo-1-hint-processor # TODO: Remove this line
12-
- ./deps

.github/workflows/publish.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ jobs:
1414
uses: actions/checkout@v2
1515
- name: Install stable toolchain
1616
uses: dtolnay/[email protected]
17-
- name: Publish crate cairo-take_until_unbalanced
18-
env:
19-
CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
20-
run: cargo publish --token ${CRATES_TOKEN} --all-features --manifest-path ./deps/parse-hyperlinks/Cargo.toml
2117
- name: Publish crate cairo-felt
2218
env:
2319
CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

Cargo.lock

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ members = [
44
"felt",
55
"vm",
66
"hint_accountant",
7-
"./deps/parse-hyperlinks",
87
]
98
exclude = ["ensure-no_std"]
109

@@ -47,14 +46,6 @@ anyhow = { version = "1.0.69", default-features = false }
4746
thiserror = { version = "1.0.32", default-features = false }
4847
thiserror-no-std = { version = "2.0.2", default-features = false }
4948

50-
# This crate has only one function `take_until_unbalanced` that is
51-
# very useful for our parsing purposes:
52-
# https://stackoverflow.com/questions/70630556/parse-allowing-nested-parentheses-in-nom
53-
# There is a proposal for extending nom::delimited to use this function:
54-
# https://github.com/Geal/nom/issues/1253
55-
parse-hyperlinks = { package = "cairo-take_until_unbalanced", path = "./deps/parse-hyperlinks", version = "0.32.0", default-features = false, features = [
56-
"alloc",
57-
] }
5849
felt = { package = "cairo-felt", path = "./felt", version = "0.8.0", default-features = false, features = [
5950
"alloc",
6051
] }

RELEASE.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
- `cairo-vm-cli/Cargo.toml`: update the version string and also the
1818
`cairo-vm` dependency version to match the above.
1919
- `felt/Cargo.toml`: update the version string.
20-
- `deps/parse-hyperlinks/Cargo.toml`: this vendored dependency needs its
21-
version bumped, but does not need to match the other crate versions.
2220
- [Here](https://github.com/lambdaclass/cairo-rs/pull/1257/files) is an
2321
example pull request with these changes.
2422
- [ ] Run `cargo update` and `git add Cargo.lock`
@@ -36,7 +34,6 @@
3634
versions.
3735
- [cairo-vm](https://crates.io/crates/cairo-vm)
3836
- [cairo-felt](https://crates.io/crates/cairo-felt)
39-
- [cairo-take-until-unbalanced](https://crates.io/crates/cairo-take_until_unbalanced)
4037
- [ ] Create a release in Github.
4138
- Select the recently created tag.
4239
- Set the title to the version string.

deps/parse-hyperlinks/Cargo.lock

Lines changed: 0 additions & 32 deletions
This file was deleted.

deps/parse-hyperlinks/Cargo.toml

Lines changed: 0 additions & 26 deletions
This file was deleted.

deps/parse-hyperlinks/LICENSE

Lines changed: 0 additions & 1 deletion
This file was deleted.

deps/parse-hyperlinks/README.md

Lines changed: 0 additions & 27 deletions
This file was deleted.

deps/parse-hyperlinks/src/lib.rs

Lines changed: 0 additions & 173 deletions
This file was deleted.

0 commit comments

Comments
 (0)