Obligatory screenshot description #43
Conversation
|
LGTM apart from the comments |
|
Comments? Have you clicked 'complete review' |
I mean, I've started a review, and added on the review some comments Edit: done I think |
johanmalm
force-pushed
the
obligatory-screenshot-description
branch
from
d06309d
to
cca1b2a
Compare
This is something that I bet every single GH user doing reviews managed to do at least once. I know for sure that I did a review, wondered why nobody responded and then some days later figured out that the review was still stuck on my end. |
| @@ -86,6 +86,17 @@ Configure sfwbar in the `~/.config/sfwbar/sfwbar.config` file. | |||
| The default config will mostly work however for more information see the | |||
| [sfwbar man page]. | |||
|
|
|||
| [sfwbar/config] contains example config files (with file extension `.config`) | |||
| which can be used by merely copying them to `~/.config/sfwbar/sfwbar.config`. | |||
| Note that if the config file contains a `include("foo.widget")` then | |||
There was a problem hiding this comment.
.widget files don't need to be copied to ~/.config/sfwbar unless the user wants to make changes to them. By default all config files are installed to {datadir}/sfwbar and sfwbar will check that location as a fallback for any files loaded through include.
There was a problem hiding this comment.
Oh, good catch and thanks for keeping an eye on us 😄
I just run sfwbar from the build directory without doing a system wide installation... which is why I had to copy the .widget files. Didn't realize it wasn't needed under 'normal' circumstances - but that does make a lot of sense.
Have done a PR to remove that paragraph. #44
No description provided.