Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement labwc #865 and #1363 #42

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ludg1e
Copy link
Contributor

@ludg1e ludg1e commented Jan 17, 2024

Apologies if I've disturbed anyone's sleep

Implements:


@ludg1e
Copy link
Contributor Author

ludg1e commented Jan 17, 2024

Oh holy, realized the user of #1363 meant the caption at the README rather than labwc.github.io

Anyway, merge or deny/close, I'm fine with both
I mean, the caption looks good in the end

Maybe it could be added somehow as well to the README

@ahesford
Copy link
Member

I think "default" conveys the wrong impression for the configuration files. They reflect the in-program defaults, but files in that location are never read by the program. "Example" is probably a better term. If there is any ambiguity to resolve, a complex phrase like "Example configuration files, which reflect the default configuration of labwc, [...]" should suffice.

@Consolatis
Copy link
Member

Consolatis commented Jan 17, 2024

That panel in the screenshot is not mate-panel but an unreleased one named "Bornel". However we should likely not refer to it as its not publicly available and I don't feel like maintaining it currently. The last time I tested mate-panel it provided a really reduced feature set when running within a wayland session. Maybe we should look into creating a new screenshot with a panel like sfwbar or xfce4-panel instead (and maybe the labwc logo, centered on a black background set via swaybg?).

Regarding /usr/share/doc/labwc/: I think we should add a usually somewhere, AFAIR when using meson install with all default settings it would be /usr/local/share/doc/labwc instead. Some distros may also not ship the files at all or place them somewhere else.

Edit:
A bit further down there is actually already this section:

Your OS/Distribution of choice may include these example configuration files in
/usr/share/doc/labwc/ or similar. If not, you could download them with:

@ludg1e
Copy link
Contributor Author

ludg1e commented Feb 3, 2024

I'm waiting for a final consensus about #7, after that my idea is to do some nice wallpapers for labwc-artwork and push a screenshot of one of them, a plain black one with the logo (cube + text), default sfwbar config and labwc-tweaks, to this PR

Edit: though if there's an urge to merge this for 0.7.1 release, a wallpaper without the text and just the logo could do the job too...

@Consolatis
Copy link
Member

Consolatis commented Feb 3, 2024

Good call, I'd like to add labwc/labwc-artwork#7 to the milestone for 0.7.1 but as its in a different repo, GH won't allow for that.

Personally I still stand by my statement in the thread that the offset to the top should be increased, similar to the organization logo at https://github.com/labwc

Edit:
Fixed issue link

@ludg1e
Copy link
Contributor Author

ludg1e commented Feb 3, 2024

Personally I still stand by my statement in the thread that the offset to the top should be increased, similar to the orga logo at https://github.com/labwc

I'm not at the day of what is going on in that issue that much

Basically, I'm mostly waiting for that issue could define a final SVG logo that defines the project face.

off-topic*
I also thought like a month ago about suggesting changing the logo font from Cantarell (quite "deprecated" nowadays in my opinion) to something that it's more widely used, though I forgot about it. Maybe now it's a good time to propose it at #7 as well?

Edit: or maybe deprecate the logo of the cube + font and just use the cube

@domo141
Copy link

domo141 commented Feb 3, 2024

hmm, failed to notice that "orca" logo even it was mentioned in that # 7...
this is pretty close to that logo:

<?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewbox="0 0 256 256"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="12">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 26 68 91 55 v 108 l -76 -61 z" />
  <path fill="#d02f90" stroke="#d02f90" d="m 229 68 -91 55 v 108 l 76 -61 z" />
</svg>

(manual trial&errors, fun to a certain point :D)

@ludg1e
Copy link
Contributor Author

ludg1e commented Feb 19, 2024

Depends on: #43

@ludg1e
Copy link
Contributor Author

ludg1e commented Feb 19, 2024

Should be ready for review, I believe

Should the caption be centered or have italic?
image

Appreciate feedback regarding the wording of Configuration section of the getting-started page (labwc/labwc #1363):

"""
Example config files, which reflect the default configuration of labwc, are located at /usr/share/doc/labwc/. You can either modify those or
create your own ones by copying them to ${XDG_CONFIG_HOME:-$HOME/.config/labwc/}
(usually ~/.config/labwc/), with the following five files being used:
[rc.xml], [menu.xml], [autostart], [environment] and [themerc-override].

Your OS/Distribution of choice may include these example configuration files. If not, you could download them with:

mkdir -p ~/.config/labwc
wget https://raw.githubusercontent.com/labwc/labwc/master/docs/environment -O ~/.config/labwc/environment
wget https://raw.githubusercontent.com/labwc/labwc/master/docs/autostart -O ~/.config/labwc/autostart
wget https://raw.githubusercontent.com/labwc/labwc/master/docs/menu.xml -O ~/.config/labwc/menu.xml
wget https://raw.githubusercontent.com/labwc/labwc/master/docs/rc.xml -O ~/.config/labwc/rc.xml

NOTE: Before using these configuration files, please read them through
and modify the content to suit your specific needs.

The example [rc.xml] has been kept simple. For all options and default values . . .
"""

@ludg1e ludg1e marked this pull request as ready for review February 19, 2024 22:30
Copy link
Contributor

@johanmalm johanmalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring. It doesn't flow well first saying that config files are located at /usr/share/.... (which they might not be btw) and then say OS/distros might include config files.

@@ -13,13 +13,14 @@ be controlled with dbus, sway/i3-IPC or other technology. The reason for this is
that we believe that custom IPCs and protocols create a fragmentation that
hinders general Wayland adoption.

<a href="img/scrot1.png">
<img src="img/scrot1-small.png">
<a href="img/scrot2.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to change the default screenshot without some dialogue first.

Also, I thing a "figure caption" looks like a report or something. That's why I added a link in template_pre.md instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There hasn't been added a "figure caption" at any moment

If you refer to this text at top message of the thread, it was just a comment of something I tried and never added (thus why the italic), maybe it was misunderstood
image

Edit: removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the caption and when clicking the img (scrot) it redirects you to the obligatory-screenshot page

@johanmalm
Copy link
Contributor

It's easier to review + merge if you submit changes in smaller batches.
Some of your proposed changes are no-brainers, but others need discussion.
Consider splitting up to separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants