Skip to content

Improvement/init callback in module #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ginccc merged 2 commits into from
Jul 17, 2017
Merged

Improvement/init callback in module #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501617b
Merge pull request #1 from labsai/master
ginccc Jul 12, 2017
48d2200
improved initialization of parser and callback module
edtechfoundry-ci-bot Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions conversationcallback-impl/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
<artifactId>httpclient-definition</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.google.inject.extensions</groupId>
<artifactId>guice-multibindings</artifactId>
<version>4.1.0</version>
</dependency>
</dependencies>

<properties>
Expand Down
8 changes: 8 additions & 0 deletions ...ioncallback-impl/src/main/java/ai/labs/callback/bootstrap/ConversationCallbackModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

import ai.labs.callback.IConversationCallback;
import ai.labs.callback.http.ConversationCallback;
import ai.labs.callback.impl.ConversationCallbackTask;
import ai.labs.lifecycle.ILifecycleTask;
import ai.labs.runtime.bootstrap.AbstractBaseModule;
import com.google.inject.Scopes;
import com.google.inject.multibindings.MapBinder;

import java.io.InputStream;

Expand All @@ -20,5 +23,10 @@ protected void configure() {
registerConfigFiles(configFiles);

bind(IConversationCallback.class).to(ConversationCallback.class).in(Scopes.SINGLETON);

MapBinder<String, ILifecycleTask> lifecycleTaskPlugins
= MapBinder.newMapBinder(binder(), String.class, ILifecycleTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.callback").to(ConversationCallbackTask.class);

}
}
4 changes: 0 additions & 4 deletions coreserver/src/main/java/ai/labs/core/bootstrap/CoreModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package ai.labs.core.bootstrap;

import ai.labs.callback.impl.ConversationCallbackTask;
import ai.labs.core.CoreRuntime;
import ai.labs.core.behavior.BehaviorRulesEvaluationTask;
import ai.labs.core.behavior.BehaviorSerialization;
Expand All @@ -10,7 +9,6 @@
import ai.labs.core.rest.internal.RestBotAdministration;
import ai.labs.core.rest.internal.RestBotEngine;
import ai.labs.lifecycle.ILifecycleTask;
import ai.labs.parser.InputParserTask;
import ai.labs.rest.rest.IRestBotAdministration;
import ai.labs.rest.rest.IRestBotEngine;
import ai.labs.runtime.IConversationCoordinator;
Expand Down Expand Up @@ -41,10 +39,8 @@ protected void configure() {
MapBinder<String, ILifecycleTask> lifecycleTaskPlugins
= MapBinder.newMapBinder(binder(), String.class, ILifecycleTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.normalizer").to(NormalizeInputTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.parser").to(InputParserTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.behavior").to(BehaviorRulesEvaluationTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.output").to(SimpleOutputTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.callback").to(ConversationCallbackTask.class);

bind(CoreRuntime.class).asEagerSingleton();
}
Expand Down
6 changes: 6 additions & 0 deletions semanticparser-impl/src/main/java/ai/labs/parser/bootstrap/SemanticParserModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package ai.labs.parser.bootstrap;

import ai.labs.lifecycle.ILifecycleTask;
import ai.labs.parser.InputParserTask;
import ai.labs.parser.rest.IRestSemanticParser;
import ai.labs.parser.rest.impl.RestSemanticParser;
import ai.labs.runtime.bootstrap.AbstractBaseModule;
import com.google.inject.multibindings.MapBinder;

/**
* @author ginccc
Expand All @@ -12,5 +15,8 @@ public class SemanticParserModule extends AbstractBaseModule {
@Override
protected void configure() {
bind(IRestSemanticParser.class).to(RestSemanticParser.class);
MapBinder<String, ILifecycleTask> lifecycleTaskPlugins
= MapBinder.newMapBinder(binder(), String.class, ILifecycleTask.class);
lifecycleTaskPlugins.addBinding("ai.labs.parser").to(InputParserTask.class);
}
}