Improvement/init callback in module - #39
Merged
ginccc merged 2 commits intoJul 17, 2017
Merged
Conversation
ginccc
added a commit
that referenced
this pull request
Jul 3, 2026
…rdering, verdict casing, groupId path validation - #29: restoreGroupPause preserves the original timeout-policy/deadline bookmark when the config re-read fails, so a failed resume no longer silently disarms a finite AUTO_REJECT/ABORT policy by persisting nulls. - #30: taskApprovals against a PHASE-paused (or task-list-less) conversation now returns 400 instead of being silently ignored and treated as a phase approve. - #35: group resume counts the metric and writes the audit entry only AFTER the resume is enqueued (mirrors the regular surface); restore uses the original pausedAt so a re-armed timeout keeps its due time. - #39: decision.verdict now parses case-insensitively (request-scoped deserializer) to match the already case-insensitive taskApprovals values. - addendum: validate the {groupId} path parameter on read/delete/cancel/approve/ approve-stream/approval-status (404 on mismatch), closing the CodeQL unused-path-param consistency hole. - addendum: de-flake resumeStartsFromNextPhase by capturing state at the synchronous resume CAS instead of the async-mutated return value.
ginccc
added a commit
that referenced
this pull request
Jul 3, 2026
…skApprovals 400, verdict casing, groupId path 404 - #3: member turn that pauses AWAITING_HUMAN is recorded SKIPPED (null content + explanatory note), its pause cancelled via conversationService, discussion still completes. - #4: a resume that re-pauses with an identical task fingerprint FAILs the discussion (ghost-agent task can never advance) — guarantees termination. - #30: taskApprovals against a PHASE pause throws IllegalArgumentException, pause survives, no CAS. - #39: lowercase/mixed-case verdict deserializes correctly; unknown verdict is nulled (friendly 400), not a raw Jackson error. - addendum: approve/cancel/approval-status under a mismatched groupId path 404; matching group proceeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.