restore value if it is set and track changes using onkeyup #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joxit
added a commit
to Joxit/riot-mui
that referenced
this pull request
Apr 1, 2017
kysonic#43 was not compatible with riot v3 Close issue kysonic#42
Joxit
reviewed
Apr 1, 2017
| @@ -22,6 +22,8 @@ | |||
| if(opts.maxRows) this.refs.mirror.style.maxHeight = opts.maxRows*this.refs[this.n].getBoundingClientRect().height + 'px'; | |||
| this.n = opts.ref||'default-textarea'; | |||
| // Defaults | |||
| this.value = opts.value || ''; | |||
| this.mirror.innerHTML = this.format(this.value); | |||
There was a problem hiding this comment.
Be carefull, this is not compatible with riot v3 and the latest version of riot-mui.
Please see riot v3 breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only issue here is the same as I brought up before in #39 .
If the value is the numerical 0 it will erase the value