Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material-input fails to display when value is 0 on type number #39

Open
mikey0000 opened this issue Mar 21, 2017 · 1 comment
Open

material-input fails to display when value is 0 on type number #39

mikey0000 opened this issue Mar 21, 2017 · 1 comment

Comments

@mikey0000
Copy link

specifically if value is zero it results in false

opts.value || ''

should be

opts.value !== undefined ? opts.value : ''

at least

also

<div class="{input-content:true,not-empty:value !== undefined,error:error}">

this needs improving more than this.
@kysonic
Copy link
Owner

kysonic commented Mar 22, 2017

@mikey0000 Agreed. Will be fixed asap.

@mikey0000 mikey0000 mentioned this issue Mar 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikey0000 @kysonic