Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alterTable table name parsing #471

Merged
merged 2 commits into from
May 13, 2023
Merged

Fix alterTable table name parsing #471

merged 2 commits into from
May 13, 2023

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented May 9, 2023

Fixes #470

@vercel
Copy link

vercel bot commented May 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 6:12pm

@hannesj hannesj mentioned this pull request May 9, 2023
Closed
@koskimas
Copy link
Member

Thank you! The fix is correct, but the test fails because there's no pets schema or name table in it (nor should there be).

@hannesj hannesj force-pushed the fix-alter-table-schema branch from 229e1a8 to 800d97d Compare May 10, 2023 14:03
@hannesj
Copy link
Contributor Author

hannesj commented May 10, 2023

Yeah, noticed it. Had some issues yesterday with installing better-sqlite3, but got it working now, so had no chance of running the tests then. Everything should be green now.

@hannesj hannesj force-pushed the fix-alter-table-schema branch from 800d97d to a2cce49 Compare May 10, 2023 18:27
@igalklebanov igalklebanov added bug Something isn't working postgres Related to PostgreSQL api Related to library's API labels May 10, 2023
@koskimas
Copy link
Member

The cleanup is not called and other tests fail now. Use before and after hooks inside your new describe block for creating and cleaning up the schema.

@hannesj hannesj force-pushed the fix-alter-table-schema branch from a2cce49 to c0c8cdf Compare May 12, 2023 07:01
koskimas
koskimas requested changes May 12, 2023
View reviewed changes
test/node/src/schema.test.ts Outdated Show resolved Hide resolved
@hannesj hannesj force-pushed the fix-alter-table-schema branch from c0c8cdf to cc6c5ca Compare May 12, 2023 11:21
@koskimas koskimas merged commit bf5613f into kysely-org:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas requested changes

Assignees
No one assigned
Labels
api Related to library's API bug Something isn't working postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to specify PostgreSQL schema when calling schema.alterTable
3 participants
@hannesj @koskimas @igalklebanov