Fix alterTable table name parsing

kysely-org · May 10, 2023 · a2cce49 · a2cce49
1 parent 9ecf9bf
commit a2cce49
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/src/operation-node/alter-table-node.ts b/src/operation-node/alter-table-node.ts
@@ -40,10 +40,10 @@ export const AlterTableNode = freeze({
     return node.kind === 'AlterTableNode'
   },
 
-  create(table: string): AlterTableNode {
+  create(table: TableNode): AlterTableNode {
     return freeze({
       kind: 'AlterTableNode',
-      table: TableNode.create(table),
+      table,
     })
   },
 

diff --git a/src/schema/schema.ts b/src/schema/schema.ts
@@ -210,7 +210,7 @@ export class SchemaModule {
     return new AlterTableBuilder({
       queryId: createQueryId(),
       executor: this.#executor,
-      node: AlterTableNode.create(table),
+      node: AlterTableNode.create(parseTable(table)),
     })
   }
 

diff --git a/test/node/src/schema.test.ts b/test/node/src/schema.test.ts
@@ -2446,6 +2446,35 @@ for (const dialect of DIALECTS) {
         })
       }
 
+      if (dialect !== 'sqlite') {
+        describe('parse schema name', () => {
+          it('should parse the schema from table name', async () => {
+            await ctx.db.schema.createSchema('pets').ifNotExists().execute()
+            await ctx.db.schema.createTable('pets.name').addColumn('id', 'serial').execute();
+
+            const builder = ctx.db.schema.alterTable('pets.name').addColumn('nickname', 'text')
+
+            testSql(builder, dialect, {
+              postgres: {
+                sql: `alter table "pets"."name" add column "nickname" text`,
+                parameters: [],
+              },
+              mysql: {
+                sql: "alter table `pets`.`name` add column `nickname` text",
+                parameters: [],
+              },
+              sqlite: NOT_SUPPORTED,
+            })
+
+            await builder.execute()
+          })
+
+          async function cleanup() {
+            await ctx.db.schema.dropSchema('pets').cascade().ifExists().execute()
+          }
+        })
+      }
+
       it('should alter a table calling query builder functions', async () => {
         const builder = ctx.db.schema
           .alterTable('test')