REL,API: 0.2.0 Start branch 0.2.0. Only process .ipynb files unless option -f is used #2
Conversation
- Processes multiple files. - Ignores all files but .ipynb files by default. - Added -f flag to force stripping other files. - This is the start of the 0.2.x branch which is maintained for now in a separate fork.
mforbes
changed the title
|
|
||
| for filename in filenames: | ||
| if not force and not filename.endswith('.ipynb'): | ||
| continue |
There was a problem hiding this comment.
Suppose we could warn/educate the user here, but otoh they could just rtfm.
|
@mforbes Have you tested this with the usage as git filter as well? I'm happy to merge this. Are you planning to continue maintaining it? I'm not too fussed about who is listed as maintainer on PyPI but feel free to add me. |
|
Is your PyPI username I have not tried things with git yet as I do not really use it. My main drive right now was to get a mercurial workflow working. Once I am happy with that, I will probably try to add something here that can be installed like your git filters (though it is more difficult since |
|
Agreed, tests would be great. I can't access my PyPI credentials right now, but will let you know what my username is. |
|
Just waiting to hear from @minrk about name and will do some testing with Git here locally. Otherwise I think this is good to go! |
|
@mforbes my PyPI user name is indeed kynan. Would be great if you could add me! |
|
@kynan You should be an owner now on PyPI. |
|
@mforbes I am, thanks! |
|
I've done some testing, seems to work fine. Merging! |
Start branch 0.2.0. Only process .ipynb files unless option -f is used
Start branch 0.2.0. Only process .ipynb files unless option -f is used
This is the version I uploaded to PyPI: nbstripout==0.2.0. I will only modify the
0.2.xrevisions and am happy to assign you as an owner or maintainer if you would like so you can upload changes. I needed a few additions to get things working with my mercurial workflow:in a separate fork.
This does change the default behaviour (which would process any file, but could throw errors if the file was not a notebook) so I have gone with a new minor revision number.