Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VER: 0.1.1: Ignore errors if not an ".ipynb" file #1

Closed
wants to merge 4 commits into from

Conversation

mforbes
Copy link
Contributor

@mforbes mforbes commented Jan 17, 2016

This changeset ignores errors in files that do not end with .ipynb and bumps the version. I would like to use this to help solve some issues with version controlling notebooks: would you be willing to push it to PyPI? I could do it too, but don't want to steal then nbstripout name if you would like to maintain it.

It seems to push fine as is, though should probably have a licence file. I tested it here:

https://testpypi.python.org/pypi?%3Aaction=pkg_edit&name=nbstripout

@mforbes
Copy link
Contributor Author

mforbes commented Jan 17, 2016

I decided to change the behavior so that only .ipynb files are processed by default. This will be faster than processing a whole bunch of files and failing. The old behaviour can be obtained with a -f flag. I also allow multiple files to be processed at once.

This version works with some mercurial aliases I am exploring in my mmf_setup project.

@mforbes
Copy link
Contributor Author

mforbes commented Jan 18, 2016

I would like to get this all working now, so my proposal is to close this PR, update my branch to 0.2 and I will push this to PyPI as nbstripout 0.2.x. I am happy to revert control to you if you want it later, and will only use versions 0.2.x so you have control of all other version numbers.

@mforbes mforbes closed this Jan 18, 2016
@kynan
Copy link
Owner

kynan commented Jan 21, 2016

Superseded by #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants