Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unstable options from clippy command #135

Merged

Conversation

cbrune
Copy link
Contributor

@cbrune cbrune commented Mar 10, 2022

This patch removes the -Zunstable-options from the default args for
the clippy command. According to rust-lang/rust-clippy#4612, this
work around is no longer needed.

Fixes: #125

@@ -178,8 +178,7 @@
"Subcommand used by `cargo-process-check'."
:type 'string)

(defcustom cargo-process--command-clippy "clippy -Zunstable-options"
"Subcommand used by `cargo-process-clippy'. Uses `-Zunstable-options` to work around https://github.com/rust-lang/rust-clippy/issues/4612."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-add the "Subcommand used by cargo-process-clippy'."` part of the docstring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed that. I pushed a new commit. PTAL.

This patch removes the `-Zunstable-options` from the default args for
the clippy command.  According to rust-lang/rust-clippy#4612, this
work around is no longer needed.

Fixes: kwrooijen#125

Signed-off-by: Curt Brune <[email protected]>
@cbrune cbrune force-pushed the curt/clippy-remove-unstable-options branch from 2f86fab to f6ac8af Compare March 10, 2022 16:35
@kwrooijen kwrooijen merged commit 8335b55 into kwrooijen:master Mar 11, 2022
@kwrooijen
Copy link
Owner

Thanks!

@cbrune cbrune deleted the curt/clippy-remove-unstable-options branch March 11, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --Zunstable-options from cargo-process--command-clippy and dependency on nightly
2 participants