Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --Zunstable-options from cargo-process--command-clippy and dependency on nightly #125

Closed
theJasonFan opened this issue Oct 28, 2021 · 1 comment · Fixed by #135
Closed

Remove --Zunstable-options from cargo-process--command-clippy and dependency on nightly #125

theJasonFan opened this issue Oct 28, 2021 · 1 comment · Fixed by #135

Comments

@theJasonFan
Copy link

The referenced issue has been resolved since Rust 1.52. (Documented in https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#others-2).

Can we remove --Zunstable-options and the dependency on an unstable release?

I'm happy to open a PR.
@c02y
Copy link
Contributor

c02y commented Dec 6, 2021

(setq cargo-process--command-clippy "clippy")

cbrune added a commit to cbrune/cargo.el that referenced this issue Mar 10, 2022
@cbrune
remove unstable options from clippy command
2f86fab 
This patch removes the `-Zunstable-options` from the default args for
the clippy command.  According to rust-lang/rust-clippy#4612, this
work around is no longer needed.

Fixes: kwrooijen#125

Signed-off-by: Curt Brune <[email protected]>
@cbrune cbrune mentioned this issue Mar 10, 2022
Merged
cbrune added a commit to cbrune/cargo.el that referenced this issue Mar 10, 2022
@cbrune
remove unstable options from clippy command
f6ac8af 
This patch removes the `-Zunstable-options` from the default args for
the clippy command.  According to rust-lang/rust-clippy#4612, this
work around is no longer needed.

Fixes: kwrooijen#125

Signed-off-by: Curt Brune <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unstable options from clippy command cbrune/cargo.el
2 participants
@c02y @theJasonFan