chore(mcp): add express deps for SDK auth router migration#1140
Merged
Conversation
Owner
Author
12 tasks
Declare express + @types/express as direct deps of packages/mcp-server so the upcoming mcpAuthRouter migration (codemem-b20m.2 onward) can import them explicitly. cors, pkce-challenge, and express-rate-limit remain transitive via @modelcontextprotocol/sdk@1.29.0. No behavior change; deps-only PR. Validates pnpm install + tsc + lint + test still pass. Part of codemem-b20m (MCP SDK migration stack).
kunickiaj
force-pushed
the
b20m.1-mcp-express-deps
branch
from
490d958 to
319cdb0
Compare
💡 Codex Review Clarify read_write scope to exclude observer ingestion
The role definition says ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced May 23, 2026
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Express and Express type dependencies required for the upcoming
@modelcontextprotocol/sdkmcpAuthRoutermigration. Also aligns repo-owned@types/nodepins with the already-decided runtime floor (engines.node >=24) so TypeScript does not validate published packages against Node 25-only APIs.Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Checklist
pnpm run lintpasses for touched files)