Skip to content

feat(mcp): add SDK OAuth provider adapter#1141

Merged
kunickiaj merged 1 commit into
mainfrom
b20m.2-mcp-oauth-provider
May 24, 2026
Merged

feat(mcp): add SDK OAuth provider adapter#1141
kunickiaj merged 1 commit into
mainfrom
b20m.2-mcp-oauth-provider

Conversation

@kunickiaj
Copy link
Copy Markdown
Owner

@kunickiaj kunickiaj commented May 23, 2026

Description

Adds the first SDK-compatible OAuth provider adapter for @codemem/mcp. The provider wraps the existing in-memory OAuth stores so the upcoming Express/SDK router migration can delegate authorization-code exchange, bearer verification, and token revocation through the MCP SDK interfaces.

Key behavior covered here:

  • Delegates authorization to the existing upstream OIDC redirect flow
  • Verifies authorization-code ownership by client and redirect URI
  • Rejects omitted or mismatched redirect_uri during token redemption
  • Carries RFC 8707 resource binding through issued access tokens and SDK AuthInfo
  • Revokes race-issued access tokens when code consumption loses a race
  • Preserves existing bearer verification and revocation behavior

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

Copy link
Copy Markdown
Owner Author

kunickiaj commented May 23, 2026

@kunickiaj kunickiaj marked this pull request as ready for review May 23, 2026 19:00
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08d6d8e70e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/mcp-server/src/provider.ts Outdated
Copy link
Copy Markdown
Owner Author

kunickiaj commented May 24, 2026

Merge activity

  • May 24, 1:33 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 24, 1:35 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 24, 1:36 AM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj kunickiaj changed the base branch from b20m.1-mcp-express-deps to graphite-base/1141 May 24, 2026 01:33
@kunickiaj kunickiaj changed the base branch from graphite-base/1141 to main May 24, 2026 01:33
@kunickiaj kunickiaj force-pushed the b20m.2-mcp-oauth-provider branch from 679ad6a to a3e5c74 Compare May 24, 2026 01:34
@kunickiaj kunickiaj merged commit 3bf4cc4 into main May 24, 2026
11 checks passed
@kunickiaj kunickiaj deleted the b20m.2-mcp-oauth-provider branch May 24, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant