Skip to content

chore(core): log replication-op emit failures in visibility/applicability mutators #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunickiaj wants to merge 1 commit into from
Closed

chore(core): log replication-op emit failures in visibility/applicability mutators #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/core/src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,8 +1195,14 @@ export class MemoryStore {
opType: "upsert",
deviceId: this.deviceId,
});
} catch {
// Non-fatal
} catch (err) {
// Non-fatal for the visibility write itself, but surface
// the failure: peers won't learn about this change until
// the next reconciliation pass, and a silent swallow
// hides whatever broke the replication path.
console.warn(
`[codemem] updateMemoryVisibility: replication-op emit failed for memory ${memoryId}: ${err instanceof Error ? err.message : String(err)}`,
);
}

const updated = this.get(memoryId);
Expand Down Expand Up @@ -1286,8 +1292,10 @@ export class MemoryStore {
opType: "upsert",
deviceId: this.deviceId,
});
} catch {
// Non-fatal — same pattern as updateMemoryVisibility.
} catch (err) {
console.warn(
`[codemem] updateMemoryApplicability: replication-op emit failed for memory ${memoryId}: ${err instanceof Error ? err.message : String(err)}`,
);
}

const updated = this.get(memoryId);
Expand Down