chore(core): log replication-op emit failures in visibility/applicability mutators

[kunickiaj]

Description

updateMemoryVisibility and updateMemoryApplicability both wrapped recordReplicationOp in a silent try/catch with "Non-fatal" as the only comment. The intent (don't fail the user-facing mutation on a replication hiccup) is correct, but the silence hides whatever actually broke the replication path — peers stop learning about the change and no signal reaches the operator.

This replaces the swallow with a structured console.warn using the existing [codemem] prefix convention (matches the rest of the codebase — e.g., db.ts, observer-client.ts, sync-discovery.ts). The warning includes the memory id and the error message so a failure leaves a forensic trail without crashing the caller. Behavior is otherwise unchanged.

Type of Change

• 🔧 Maintenance (refactor, chore, CI, etc.)

Testing

• Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test) — workspace 1995/1995
• Added/updated tests for changes — observability-only change, no new tests; the existing replication-op emit tests already exercise the happy path
• Manually verified changes work as expected — log message format matches existing [codemem] log lines

Checklist

• Code follows project style (pnpm run lint passes for touched files)
• Self-review completed
• Documentation updated (if needed) — N/A
• No new warnings introduced

[kunickiaj]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(core): log replication-op emit failures in visibility/applicability mutators #1107 👈 (View in Graphite)
• feat(core): split sticky_tokens from pack_tokens so token_budget is honest #1106
• feat(viewer): expose org/toolchain layers in the applicability picker #1105
• feat(core): inject a Sticky Rules band at the top of every memory pack #1104
• feat(viewer): expose applies_to mutation via store + endpoint + feed card #1103
• feat(core): add applies_to field for layered sticky-rules foundation #1102
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[kunickiaj]

Scrapping the layered sticky-rules feature stack. The manual user-pinning premise — "user finds a memory in the feed and clicks a dropdown to broaden its scope" — is friction nobody will reach for. The valuable sticky rules ("use fish shell", "no praise filler") are not memories users would find and pin; they are recurring patterns the observer should infer, and the canonical homes for them already exist (~/.claude/CLAUDE.md for personal prefs, repo AGENTS.md for project rules).

Salvaging the one pre-existing bug surfaced during this work as a focused standalone PR: the silent try/catch swallow around recordReplicationOp in updateMemoryVisibility (the method this PR did not introduce) now logs the failure with the existing [codemem] prefix instead of dropping it on the floor.