Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Build fails with Go 1.23 because of changed testing.testDeps #546

Closed
stefanb opened this issue Aug 2, 2024 · 2 comments · Fixed by #548
Closed

[Bug]: Build fails with Go 1.23 because of changed testing.testDeps #546

stefanb opened this issue Aug 2, 2024 · 2 comments · Fixed by #548
Labels
bug Something isn't working

Comments

@stefanb
Copy link

stefanb commented Aug 2, 2024

What happened:

build fails with

# github.com/kudobuilder/kuttl/pkg/test/utils
  pkg/test/utils/testing.go:44:28: cannot use &testDeps{} (value of type *testDeps) as "testing".testDeps value in argument to testing.MainStart: *testDeps does not implement "testing".testDeps (missing method InitRuntimeCoverage)

What you expected to happen:

build to succeed.

How to reproduce it (as minimally and precisely as possible):

  1. Install Go 1.23 (rc1, rc2 or later)
  2. build

Anything else we need to know?:

Related:

Environment:

  • Kubernetes version (use kubectl version):
  • KUTTL version (use kubectl kuttl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@stefanb stefanb added the bug Something isn't working label Aug 2, 2024
@porridge
Copy link
Member

porridge commented Aug 5, 2024

Thanks for the report @stefanb !
Looks like we'll need something similar to https://github.com/hofstadter-io/hof/pull/392/files#diff-f08861a287bce287f8852024b94cd158021f70f1b18fdd846aabbde6d3bfc607R69 including making the testing.MainStart call versioned with build tags 🤔

@porridge
Copy link
Member

porridge commented Aug 5, 2024

@stefanb can you please check if #548 works for you?

stefanb added a commit to Homebrew/homebrew-core that referenced this issue Aug 17, 2024
use "go" againg after kudobuilder/kuttl#546 is fixed and released

Follow-up to #175310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants