Build fails with Go 1.23 because of changed testing.testDeps

[stefanb]

When trying to build with Go 1.23 rc1 in

• go 1.23, [email protected] 1.22.6 (new formula) Homebrew/homebrew-core#175310

It failed at

hof/script/runtime/exe_next.go

Line 52 in bebc58f

m := testing.MainStart(nopTestDeps{}, nil, nil, nil, nil)

with error:

  # github.com/hofstadter-io/hof/script/runtime
  script/runtime/exe_next.go:52:26: cannot use nopTestDeps{} (value of type nopTestDeps) as testing.testDeps value in argument to testing.MainStart: nopTestDeps does not implement testing.testDeps (missing method InitRuntimeCoverage)

InitRuntimeCoverage was added by @rsc in:
golang/go@180ea45#diff-36f401ff1ffadb7d7a39cf41c2329615b159fa95cf2e14c1f58d8c46331af429R208

See

• cmd/link: lock down future uses of linkname golang/go#67401
• https://tip.golang.org/doc/go1.23#linker
• https://github.com/golang/go/blob/82c14346d89ec0eeca114f9ca0e88516b2cda454/src/testing/internal/testdeps/deps.go#L218-L223

Given the NOP nature of nopTestDeps a possible workaround could be to just implement a dummy/nop function InitRuntimeCoverage() in the nopTestDeps:

func (nopTestDeps) InitRuntimeCoverage() (mode string, tearDown func(string, string) (string, error), snapcov func() float64) {
	return
}

[verdverm]

Living on the edge eh?! Thanks for the heads up and initial investigation

We've seen this before, it's one area where Go is not API stable :[

I can probably roll over the old/new exe files and the build directives therein

• https://github.com/hofstadter-io/hof/blob/_dev/script/runtime/exe_next.go#L5
• https://github.com/hofstadter-io/hof/blob/_dev/script/runtime/exe_old.go#L5

[verdverm]

@stefanb please let me know if _dev branch (our main branch) works for you now

I'm going to look at updating CUE to 0.9.1+ or maybe a 0.10.0-beta/rc and then cut a new version

[stefanb]

@verdverm the most i could (quickly) test is if it builds or run some unit tests, not all the functionality in practice. Would that really be enough?

[verdverm]

yeah, just whatever is failing for you. I find it unlikely this changed any behavior you rely on, unless you are using the hidden hof run command (which is based on the testscript package both Go & CUE use, but exposed as a scripting language)

[stefanb]

Still needs a release > v0.6.9 that includes fix from #392, see: https://github.com/hofstadter-io/hof/releases

[verdverm]

@stefanb just cut a new release candidate