Add podman to bootstrap images#2196
Merged
kubevirt-bot merged 1 commit intokubevirt:mainfrom Jul 14, 2022
Merged
Conversation
Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
added
the
dco-signoff: yes
Member
|
/lgtm |
Contributor
Author
brianmcarey
approved these changes
Jul 14, 2022
Member
brianmcarey
left a comment
brianmcarey
left a comment
There was a problem hiding this comment.
Sorry for the delay in looking at this - I wanted to make sure it wouldn't cause any confusion for the e2e workloads. Tested it locally with phaino and it looks good.
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
maya-r
added a commit
to maya-r/project-infra
that referenced
this pull request
Jul 20, 2022
This reverts commit 139f21b. The PRs needing podman specifically were re-written so docker is supported as well, to aid the proposed plan of gradually transitioning CI lanes to podman by having a separate podman-only image. Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
This reverts commit 139f21b. The PRs needing podman specifically were re-written so docker is supported as well, to aid the proposed plan of gradually transitioning CI lanes to podman by having a separate podman-only image. Signed-off-by: Maya Rashish <mrashish@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so we can merge the code in kubevirt/hostpath-provisioner#115
(The golang image used by hostpath-provisioner presubmits is based on the bootstrap image)