Switch to using podman, cleanup build logic#72
Merged
Conversation
Signed-off-by: Maya Rashish <mrashish@redhat.com>
We don't use it for testing. One less use of docker. Signed-off-by: Maya Rashish <mrashish@redhat.com>
Signed-off-by: Maya Rashish <mrashish@redhat.com>
Signed-off-by: Maya Rashish <mrashish@redhat.com>
Note that the kubevirtci docker is already podman, so there's no change in the ssh.sh node01 code. It's just helpful to know that we make no references to docker. We don't relabel the directory to avoid permission errors on rootless podman. We don't validate tls when pushing to local repository, as it doesn't have a valid certificate. Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
added
dco-signoff: yes
Contributor
Author
|
/retest |
Having podman on the CI has proven risky - it is breaking random other CI lanes. We will transition gradually by supporting both on all our repos & then moving CI images one by one. Signed-off-by: Maya Rashish <mrashish@redhat.com>
brybacki
reviewed
Jul 25, 2022
brybacki
reviewed
Jul 25, 2022
Contributor
|
looks good, just two questions in review comments |
Unclear why we do this, and it breaks the build. It might be a problem introduced by using a newer image and Go version. Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r
force-pushed
the
docker-not-needed
branch
from
c9f80e6 to
d8044e8
Compare
Contributor
Author
|
Edited to point out we don't depend on any project-infra PR, I forgot to remove that. |
Contributor
|
Looks like the memory set in config.sh does not work because it is done too late. So your addition to ci script was actually good. |
Contributor
|
/test pull-kvp-functional-test |
This previously didn't work because hack/cluster-up/common.sh is run first. Change the order so we successfully override the size. Signed-off-by: Maya Rashish <mrashish@redhat.com>
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brybacki The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: