Undo workaround to reduce bundle size by zcahana · Pull Request #1445 · kubevirt/hyperconverged-cluster-operator

zcahana · 2021-07-19T10:29:45Z

Following OLM support for bundle compression (operator-framework/operator-registry#685, operator-framework/operator-lifecycle-manager#2240), this PR removes the workaround introduced in #1396 to reduce the size of the HCO bundle so that it does not exceed 1MiB.

With the workaround removed, the 1.5.0 bundle size is 1.1M:

$ du -d0 -h deploy/olm-catalog/community-kubevirt-hyperconverged/1.5.0/
1.1M    deploy/olm-catalog/community-kubevirt-hyperconverged/1.5.0/

Marking this as WIP for now, we should first see if this PR passes openshift-ci (which should be running with a compression-enabled OLM), and later on we can determine if this should be merged now or at some later point.

Reviewer Checklist

Release note:

NONE

zcahana · 2021-07-19T10:30:24Z

/cc @tiraboschi @orenc1 @nunnatsa

coveralls · 2021-07-19T10:33:18Z

Pull Request Test Coverage Report for Build 1093957093

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.067%

Totals
Change from base Build 1093905309:	0.0%
Covered Lines:	3118
Relevant Lines:	4450

💛 - Coveralls

zcahana · 2021-07-19T15:43:55Z

CI failures (e.g. this) indicate that OLM version on openshift-ci doesn't yet support compression:

time="2021-07-19T11:27:38Z" level=info msg="Using in-cluster kube client config"
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/cluster-network-addons00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/containerized-data-importer00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/hco00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/hco01.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/hco02.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/hostpath-provisioner00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/kubevirt-hyperconverged-operator.v1.5.0.clusterserviceversion.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/kubevirt00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/node-maintenance00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/scheduling-scale-performance00.crd.yaml
time="2021-07-19T11:27:38Z" level=info msg="Reading file" file=/bundle/manifests/vm-import-operator00.crd.yaml
time="2021-07-19T11:27:38Z" level=error msg="Bundle files exceeded 1048576 bytes limit" file=/bundle/manifests/vm-import-operator00.crd.yaml

However, the remainder of the error message indicates that the opm version used in the openshift-ci does support compression (see the new --gzip flag):

Error: error loading manifests from directory: bundle files exceeded 1048576 bytes limit
Usage:
  opm alpha bundle extract [flags]

Flags:
  -c, --configmapname string   name of configmap to write bundle data
  -l, --datalimit uint         maximum limit in bytes for total bundle data (default 1048576)
      --debug                  enable debug logging
  -z, --gzip                   enable gzip compression of configmap data
  -h, --help                   help for extract
  -k, --kubeconfig string      absolute path to kubeconfig file
  -m, --manifestsdir string    path to directory containing manifests (default "/")
  -n, --namespace string       namespace to write configmap data (default "openshift-operator-lifecycle-manager")

Global Flags:
      --skip-tls   skip TLS certificate verification for container image registries while pulling bundles or index

I assume this happens since operator-framework/operator-registry#685 has already been promoted to openshift-ci, whereas the recently merged operator-framework/operator-lifecycle-manager#2240 hasn't yet.

zcahana · 2021-07-19T15:54:47Z

Tracking openshift/operator-framework-olm#122 which will downstream the gzip compression support into openshift.

zcahana · 2021-07-22T15:12:52Z

Tracking openshift/operator-framework-olm#122 which will downstream the gzip compression support into openshift.

The referenced PR was replaced/superseded by openshift/operator-framework-olm#129, which is now merged.

/retest

hco-bot · 2021-07-22T17:06:30Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-07-22T17:06:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

Details

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-07-22T18:29:27Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-07-22T18:29:30Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

Details

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-07-23T15:19:54Z

/retest

hco-bot · 2021-07-24T15:53:39Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-07-24T15:53:41Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

Details

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-07-24T17:25:53Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-07-24T17:25:55Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

Details

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-07-24T21:40:22Z

/retest

zcahana · 2021-07-25T09:09:57Z

This now fail only on the OKD lanes (with the same errors about the 1MiB limit).

zcahana · 2021-07-27T12:39:52Z

/retest

kubevirt-bot · 2021-08-03T14:20:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-aws

Details

In response to this:

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-03T14:29:07Z

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-08-03T14:29:17Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp

Details

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-08-03T15:53:58Z

/retest

hco-bot · 2021-08-03T15:54:00Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-08-03T15:54:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

Details

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-08-03T19:06:42Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-08-03T19:06:46Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

Details

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-08-03T21:07:26Z

/retest

hco-bot · 2021-08-03T22:35:29Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-08-03T22:35:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

Details

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-08-04T07:20:43Z

/retest

openshift-ci · 2021-08-04T08:45:16Z

@zcahana: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-image-index-gcp	`ea16f52`	link	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-image-index-aws	`ea16f52`	link	`/test hco-e2e-image-index-aws`
ci/prow/okd-hco-e2e-image-index-aws	`ea16f52`	link	`/test okd-hco-e2e-image-index-aws`
ci/prow/hco-e2e-kv-smoke-gcp	`ea16f52`	link	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-index-aws	`ea16f52`	link	`/test hco-e2e-upgrade-index-aws`
ci/prow/okd-hco-e2e-upgrade-index-aws	`ea16f52`	link	`/test okd-hco-e2e-upgrade-index-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-08-04T08:46:09Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-08-04T08:46:14Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

Details

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1

/approve

kubevirt-bot · 2021-08-04T09:12:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [orenc1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2021-08-04T09:45:32Z

/retest

orenc1 · 2021-08-04T10:32:45Z

🎉

Signed-off-by: Zvi Cahana <zvic@il.ibm.com>

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jul 19, 2021

kubevirt-bot requested review from erkanerol and tiraboschi July 19, 2021 10:30

kubevirt-bot requested review from nunnatsa and orenc1 July 19, 2021 10:30

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021

tiraboschi force-pushed the undo_bundle_shrink branch from f194c25 to 3f657b9 Compare July 24, 2021 14:26

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021

zcahana changed the title ~~WIP: Undo workaround to reduce bundle size~~ Undo workaround to reduce bundle size Jul 26, 2021

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021

orenc1 approved these changes Aug 4, 2021

View reviewed changes

kubevirt-bot assigned orenc1 Aug 4, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021

kubevirt-bot merged commit 413b9ed into kubevirt:main Aug 4, 2021

zcahana deleted the undo_bundle_shrink branch August 4, 2021 10:25

orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Aug 24, 2021

Undo remove descriptions from old CRDs (kubevirt#1445)

2f08952

Signed-off-by: Zvi Cahana <zvic@il.ibm.com>

orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Aug 29, 2021

Undo remove descriptions from old CRDs (kubevirt#1445)

504388a

Signed-off-by: Zvi Cahana <zvic@il.ibm.com>

Conversation

zcahana commented Jul 19, 2021

Uh oh!

zcahana commented Jul 19, 2021

Uh oh!

coveralls commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 1093957093

💛 - Coveralls

Uh oh!

zcahana commented Jul 19, 2021

Uh oh!

zcahana commented Jul 19, 2021

Uh oh!

zcahana commented Jul 22, 2021

Uh oh!

hco-bot commented Jul 22, 2021

Uh oh!

kubevirt-bot commented Jul 22, 2021

Uh oh!

hco-bot commented Jul 22, 2021

Uh oh!

kubevirt-bot commented Jul 22, 2021

Uh oh!

tiraboschi commented Jul 23, 2021

Uh oh!

hco-bot commented Jul 24, 2021

Uh oh!

kubevirt-bot commented Jul 24, 2021

Uh oh!

hco-bot commented Jul 24, 2021

Uh oh!

kubevirt-bot commented Jul 24, 2021

Uh oh!

tiraboschi commented Jul 24, 2021

Uh oh!

zcahana commented Jul 25, 2021

Uh oh!

zcahana commented Jul 27, 2021

Uh oh!

kubevirt-bot commented Aug 3, 2021

Uh oh!

hco-bot commented Aug 3, 2021

Uh oh!

kubevirt-bot commented Aug 3, 2021

Uh oh!

tiraboschi commented Aug 3, 2021

Uh oh!

hco-bot commented Aug 3, 2021

Uh oh!

kubevirt-bot commented Aug 3, 2021

Uh oh!

hco-bot commented Aug 3, 2021

Uh oh!

kubevirt-bot commented Aug 3, 2021

Uh oh!

tiraboschi commented Aug 3, 2021

Uh oh!

hco-bot commented Aug 3, 2021

Uh oh!

kubevirt-bot commented Aug 3, 2021

Uh oh!

tiraboschi commented Aug 4, 2021

Uh oh!

openshift-ci Bot commented Aug 4, 2021

Uh oh!

hco-bot commented Aug 4, 2021

Uh oh!

kubevirt-bot commented Aug 4, 2021

Uh oh!

orenc1 left a comment

Choose a reason for hiding this comment

Uh oh!

kubevirt-bot commented Aug 4, 2021

Uh oh!

tiraboschi commented Aug 4, 2021

Uh oh!

orenc1 commented Aug 4, 2021

Uh oh!

Reviewers

coveralls commented Jul 19, 2021 •

edited

Loading