Skip to content

Remove descriptions from unstored versions of CRDs#1396

Merged
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
tiraboschi:reduce_bundle_size
Jun 15, 2021
Merged

Remove descriptions from unstored versions of CRDs#1396
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
tiraboschi:reduce_bundle_size

Conversation

@tiraboschi
Copy link
Copy Markdown
Member

@tiraboschi tiraboschi commented Jun 14, 2021

Remove descriptions from unstored versions of CRDs
to keep the bundle size < 1MiB.

Until operator-framework/enhancements#40
got implemented, a bundle should not exceed 1MiB
because its internally implemented with a configmap.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Remove descriptions from unstored versions of CRDs

@tiraboschi tiraboschi requested review from nunnatsa and orenc1 June 14, 2021 13:12
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Jun 14, 2021
@kubevirt-bot kubevirt-bot requested a review from erkanerol June 14, 2021 13:12
@tiraboschi tiraboschi force-pushed the reduce_bundle_size branch from b42005e to c6019b6 Compare June 14, 2021 13:12
@tiraboschi
Copy link
Copy Markdown
Member Author

tiraboschi commented Jun 14, 2021

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 936151948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.045%
Totals Coverage Status
Change from base Build 935906218: 0.0%
Covered Lines: 2979
Relevant Lines: 4253
💛 - Coveralls

@tiraboschi tiraboschi force-pushed the reduce_bundle_size branch from c6019b6 to 9d25c0d Compare June 14, 2021 13:46
@tiraboschi
Copy link
Copy Markdown
Member Author

tiraboschi commented Jun 14, 2021

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
orenc1
orenc1 reviewed Jun 14, 2021
View reviewed changes
Comment thread deploy/crds/hco01.crd.yaml Outdated
@tiraboschi tiraboschi force-pushed the reduce_bundle_size branch from 9d25c0d to b6780f7 Compare June 14, 2021 14:31
@tiraboschi
Remove descriptions from unstored versions of CRDs
c6b4259 
Remove descriptions from unstored versions of CRDs
to keep the bundle size < 1MiB.

Until operator-framework/enhancements#40
got implemented, a bundle should not exceed 1MiB
because its internally (in the opm tool) managed
with a configmap.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi force-pushed the reduce_bundle_size branch from b6780f7 to c6b4259 Compare June 14, 2021 14:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tiraboschi tiraboschi requested a review from orenc1 June 14, 2021 14:41
@tiraboschi tiraboschi mentioned this pull request Jun 14, 2021
Closed
@hco-bot
Copy link
Copy Markdown
Collaborator

hco-bot commented Jun 14, 2021

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 14, 2021

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-upgrade-index-aws

Details

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Copy Markdown
Collaborator

hco-bot commented Jun 14, 2021

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 14, 2021

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

Details

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Copy Markdown
Collaborator

hco-bot commented Jun 14, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 14, 2021

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

Details

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Copy Markdown
Member Author

tiraboschi commented Jun 14, 2021

/retest

1 similar comment
@tiraboschi
Copy link
Copy Markdown
Member Author

tiraboschi commented Jun 14, 2021

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2021 •
edited
Loading

@tiraboschi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-aws c6b4259 link /test hco-e2e-image-index-aws
ci/prow/hco-e2e-upgrade-index-aws c6b4259 link /test hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-image-index-gcp c6b4259 link /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-kv-smoke-gcp c6b4259 link /test hco-e2e-kv-smoke-gcp
ci/prow/okd-hco-e2e-image-index-azure c6b4259 link /test okd-hco-e2e-image-index-azure
ci/prow/okd-hco-e2e-upgrade-index-azure c6b4259 link /test okd-hco-e2e-upgrade-index-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Copy Markdown
Collaborator

hco-bot commented Jun 14, 2021

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 14, 2021

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-azure

Details

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Copy Markdown
Collaborator

hco-bot commented Jun 14, 2021

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 14, 2021

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-azure

Details

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@kubevirt-bot
Copy link
Copy Markdown
Contributor

kubevirt-bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@kubevirt-bot kubevirt-bot merged commit 09f6017 into kubevirt:main Jun 15, 2021
@wallrj wallrj mentioned this pull request Jun 21, 2021
Merged
8 tasks
@zcahana zcahana mentioned this pull request Jul 19, 2021
Merged
11 tasks
@tiraboschi tiraboschi deleted the reduce_bundle_size branch July 19, 2021 10:31
orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Aug 24, 2021
@tiraboschi @orenc1
Remove descriptions from unstored versions of CRDs (kubevirt#1396)
97e393a 
Remove descriptions from unstored versions of CRDs
to keep the bundle size < 1MiB.

Until operator-framework/enhancements#40
got implemented, a bundle should not exceed 1MiB
because its internally (in the opm tool) managed
with a configmap.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Aug 29, 2021
@tiraboschi @orenc1
Remove descriptions from unstored versions of CRDs (kubevirt#1396)
a6281ab 
Remove descriptions from unstored versions of CRDs
to keep the bundle size < 1MiB.

Until operator-framework/enhancements#40
got implemented, a bundle should not exceed 1MiB
because its internally (in the opm tool) managed
with a configmap.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@erkanerol erkanerol Awaiting requested review from erkanerol

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@nunnatsa nunnatsa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiraboschi @coveralls @hco-bot @kubevirt-bot @orenc1 @nunnatsa