Skip to content

Fix comment typo in checkECRRegistry function to clarify _catalog end… #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnathangreeg merged 1 commit into from
Feb 2, 2026
Merged

Fix comment typo in checkECRRegistry function to clarify _catalog end… #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion watcher/registryhandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func (ch *RegistryCommandsHandler) checkRegistry(cmd v1alpha1.OperatorCommand) (
return payload, nil
}

// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issues
// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issue
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent terminology with Line 162.

The comment on Line 162 uses "issues" (plural), while this line now uses "issue" (singular). Both comments describe the same ECR _catalog endpoint problem and should use consistent terminology.

📝 Proposed fix to ensure consistency

If referring to a single specific issue, update Line 162 as well:

-// Use AWS SDK for ECR to avoid _catalog endpoint issues
+// Use AWS SDK for ECR to avoid _catalog endpoint issue

If referring to multiple issues, revert this change:

-// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issue
+// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issues
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issue
// Uses AWS SDK instead of HTTP calls for ECR to avoid _catalog endpoint issues
🤖 Prompt for AI Agents 
In `@watcher/registryhandler.go` at line 191, Update the comment "Uses AWS SDK
instead of HTTP calls for ECR to avoid _catalog endpoint issue" so its
terminology matches the earlier comment at Line 162 by using "issues" (plural)
instead of "issue"; locate the comment string in registryhandler.go and change
"_catalog endpoint issue" to "_catalog endpoint issues" to make the wording
consistent with the other comment.

func (ch *RegistryCommandsHandler) checkECRRegistry(registry armotypes.ContainerImageRegistry) ([]byte, error) {
var registryURI string
if awsRegistry, ok := registry.(*armotypes.AWSImageRegistry); ok {
Expand Down
Loading