Add unit tests for Azure ResourceGroup parsing

[slashben]

Summary

Add comprehensive unit tests for the Azure ResourceGroup parsing functionality that was merged in #697.

Test Coverage

• ✅ Tests for parseAzureResourceGroup with 9 test cases covering:

  • Valid Azure providerID formats from AKS
  • Case-insensitive matching (uppercase, mixed case)
  • Edge cases (no trailing path, empty strings, malformed IDs)
  • Non-Azure providerIDs

• ✅ Tests for enrichCloudMetadataForAzure with 5 test cases covering:

  • Successful enrichment from valid providerID
  • Guard conditions (wrong provider, already set ResourceGroup, nil metadata)
  • No change when resourceGroups marker is missing

Test Results

All 14 test cases pass successfully:

=== RUN   TestParseAzureResourceGroup
--- PASS: TestParseAzureResourceGroup (0.00s)
=== RUN   TestEnrichCloudMetadataForAzure
--- PASS: TestEnrichCloudMetadataForAzure (0.00s)
PASS
ok  	github.com/kubescape/node-agent/pkg/cloudmetadata	0.047s

Related

• Follows up on Add Azure ResourceGroup enrichment to CloudMetadata #697 which added the Azure ResourceGroup enrichment functionality

Summary by CodeRabbit

• Tests
  • Added unit tests for Azure resource group parsing from providerIDs, including validation of various formats and edge cases.
  • Added unit tests for Azure cloud metadata enrichment, covering conditional data population and error handling scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds comprehensive unit tests for Azure resource group parsing and cloud metadata enrichment functions, covering valid and invalid providerID formats, edge cases, and enrichment behavior conditions.

Changes

Cohort / File(s)	Summary
Azure Metadata Tests pkg/cloudmetadata/metadata_test.go	Added TestParseAzureResourceGroup validating providerID parsing with case-insensitive matching, hyphen/underscore handling, and error cases (missing segment, empty/malformed IDs, non-Azure providers). Added TestEnrichCloudMetadataForAzure validating conditional enrichment logic (Azure provider check, ResourceGroup population from providerID, nil metadata handling).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add Azure ResourceGroup enrichment to CloudMetadata #697: Introduces the parseAzureResourceGroup and enrichCloudMetadataForAzure functions that are directly tested in this PR.

Suggested reviewers

• matthyx

Poem

🐰 Azure resources grouped with care,
Tests validate each format fair,
With hyphens, cases, edge cases too,
Metadata enrichment shines bright and true! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding unit tests for Azure ResourceGroup parsing, which is the primary content of the pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pkg/cloudmetadata/metadata_test.go`:
- Around line 132-143: The test case named "no change if providerID doesn't
contain resourceGroups" is inconsistent: its name implies no-change but
wantUnchanged is false; update the test to reflect intent by setting
wantUnchanged to true (or alternatively rename the case to indicate a change).
Locate the table-driven test entry (the struct with fields name, node
(corev1.Node with Spec.ProviderID
"azure:///subscriptions/.../virtualMachines/vm1"), cMetadata
(armotypes.CloudMetadata with ProviderAzure), wantRG, and wantUnchanged) and
change wantUnchanged from false to true so the expectation matches the case
name.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Align the “no change” case with its expectation.

The case name says “no change,” but wantUnchanged is false. This weakens the intent of the test.

🔧 Suggested fix

-			wantUnchanged: false,
+			wantUnchanged: true,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	name: "no change if providerID doesn't contain resourceGroups",
	node: &corev1.Node{
	Spec: corev1.NodeSpec{
	ProviderID: "azure:///subscriptions/sub-id/providers/Microsoft.Compute/virtualMachines/vm1",
	},
	},
	cMetadata: &armotypes.CloudMetadata{
	Provider: armotypes.ProviderAzure,
	},
	wantRG: "",
	wantUnchanged: false,
	},
	name: "no change if providerID doesn't contain resourceGroups",
	node: &corev1.Node{
	Spec: corev1.NodeSpec{
	ProviderID: "azure:///subscriptions/sub-id/providers/Microsoft.Compute/virtualMachines/vm1",
	},
	},
	cMetadata: &armotypes.CloudMetadata{
	Provider: armotypes.ProviderAzure,
	},
	wantRG: "",
	wantUnchanged: true,
	},

🤖 Prompt for AI Agents

In `@pkg/cloudmetadata/metadata_test.go` around lines 132 - 143, The test case
named "no change if providerID doesn't contain resourceGroups" is inconsistent:
its name implies no-change but wantUnchanged is false; update the test to
reflect intent by setting wantUnchanged to true (or alternatively rename the
case to indicate a change). Locate the table-driven test entry (the struct with
fields name, node (corev1.Node with Spec.ProviderID
"azure:///subscriptions/.../virtualMachines/vm1"), cMetadata
(armotypes.CloudMetadata with ProviderAzure), wantRG, and wantUnchanged) and
change wantUnchanged from false to true so the expectation matches the case
name.