Skip to content

Fix metadata for PodCertificateRequest feature gate #51915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Fix metadata for PodCertificateRequest feature gate #51915

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e31c3
Fix PodCertificateRequests feature gate metadata
lmktfy Aug 14, 2025
c7c7c83
Fix name of feature gate file
lmktfy Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../reference/command-line-tools-reference/feature-gates/PodCertificateRequests.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the info in the KEP docs (kep.yaml and README.md) and code (here) in release-1.34 branch, it looks like the intended feature gate name is PodCertificateRequest. We should consider updating the name of this feature gate description file for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed!

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ stages:
- stage: alpha
defaultValue: false
fromVersion: "1.34"
toVersion: "1.37"
---
Enable PodCertificateRequest objects and podCertificate projected volume
sources.