Skip to content

Conversation

@lmktfy
Copy link
Member

@lmktfy lmktfy commented Aug 14, 2025

  • Fix a bug where we make a statement about the future (that PodCertificateRequest either graduates or is removed in v1.38), even though we avoid making these.
  • Use the correct filename for the file about this feature gate

/milestone 1.34

Fixup for PR #51817

@k8s-ci-robot k8s-ci-robot modified the milestone: 1.34 Aug 14, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano August 14, 2025 18:28
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2025
@netlify
Copy link

netlify bot commented Aug 14, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c7c7c83
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68a20464183e0600081c6110

@netlify
Copy link

netlify bot commented Aug 14, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c7c7c83
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68a2046420754000088ee33b
😎 Deploy Preview https://deploy-preview-51915--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the info in the KEP docs (kep.yaml and README.md) and code (here) in release-1.34 branch, it looks like the intended feature gate name is PodCertificateRequest. We should consider updating the name of this feature gate description file for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed!

@lmktfy lmktfy changed the title Fix metadata for PodCertificateRequests feature gate Fix metadata for PodCertificateRequest feature gate Aug 17, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a01f3f3c14a6c6701d0cd42358f8f86a2cd4f27f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1686437 into kubernetes:dev-1.34 Aug 18, 2025
6 checks passed
@lmktfy lmktfy deleted the 20250814_fix_pcr_feature_gate branch September 20, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants