KEP-4603: Docs for feature behind ReduceDefaultCrashLoopBackoffDecay feature gate #50065
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
lauralorenz
force-pushed
the
ReduceDefaultCrashLoopBackoffDecay-docs
branch
from
13a2570 to
b1bbfca
Compare
k8s-ci-robot
added
language/en
lauralorenz
force-pushed
the
ReduceDefaultCrashLoopBackoffDecay-docs
branch
4 times, most recently
from
8b98958 to
1799a45
Compare
| delays on that node will still start at 10s and increase exponentially by 2x | ||
| each restart, but will now be capped at your configured maximum. If the | ||
| `maxContainerRestartPeriod` you configure is less than the default initial value | ||
| of 10s, the initial delay will instead be set to the configured maximum. |
There was a problem hiding this comment.
I ended up leaving this the same as before -- I thought about making it more generic sounding ("default initial value for your cluster" instead of "default initial value of 10s") but I thought for most people they will want to come to these docs and see the effect in concrete terms not assuming they are using another alpha gate, and only people who opt to use BOTH alpha gates should have to reason about if they have a different default or not.
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Laura Lorenz <[email protected]>
lauralorenz
force-pushed
the
ReduceDefaultCrashLoopBackoffDecay-docs
branch
from
1799a45 to
a9286d5
Compare
| {{< feature-state | ||
| feature_gate_name="ReduceDefaultCrashLoopBackOffDecay" >}} | ||
|
|
||
| With the alpha feature gate `ReduceDefaultCrashLoopBackOffDecay` enabled, |
There was a problem hiding this comment.
nit: we'd like this to be a default, right? I would suggest to put a note in the paragraph above that the numbers listed are only applicable when the feature gate is disabled. It may be too early for alpha, but when it goes to beta we will for sure switch numbers in paragraph above and change this section to "Old restart delay numbers".
There was a problem hiding this comment.
I think this it too early to do that now because I don't want to clutter up the "normal" docs with stuff that is for alpha people only right now. But yes I will hoist it up more strongly at beta.
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
/lgtm
with the small suggestion
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 5757206b7e7cce0af5d7b922582bf09e1d52906b |
|
For convenience, here is the direct link to the netlify deploy of the changed section: https://deploy-preview-50065--kubernetes-io-vnext-staging.netlify.app/docs/concepts/workloads/pods/pod-lifecycle/#reduced-container-restart-delay |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
Description
Docs changes for alpha feature ReduceDefaultCrashLoopBackOffDecay to CrashLoopBackoff behavior per KEP-4603
Issue
kubernetes/enhancements: kubernetes/enhancements#4603
kubernetes/kubernetes PRs: