Skip to content

Conversation

@rayandas
Copy link
Member

@rayandas rayandas commented Apr 15, 2025

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR refactors and fine-tunes all the release-notes for v1.33.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from rytswd April 15, 2025 05:42
@k8s-ci-robot k8s-ci-robot added the area/release-team Issues or PRs related to the release-team subproject label Apr 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from wendy-ha18 April 15, 2025 05:42
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2025
@rayandas rayandas force-pushed the 1.33-final-release-note-draft branch from a802f9b to f620035 Compare April 15, 2025 16:46
@rayandas rayandas changed the title [WIP] Kubernetes v1.33 Release Notes final draft Kubernetes v1.33 Release Notes final draft Apr 15, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@rayandas rayandas force-pushed the 1.33-final-release-note-draft branch 2 times, most recently from 1fa800c to 2da433b Compare April 16, 2025 06:05
Signed-off-by: Rayan Das <[email protected]>
Co-authored-by: Nina Polshakova <[email protected]>
@rayandas rayandas force-pushed the 1.33-final-release-note-draft branch from 2da433b to 237c3c7 Compare April 18, 2025 15:34
@rayandas rayandas force-pushed the 1.33-final-release-note-draft branch from f341b09 to 4babc27 Compare April 18, 2025 17:04
Signed-off-by: Rayan Das <[email protected]>
@rayandas rayandas force-pushed the 1.33-final-release-note-draft branch from d842e96 to 8249291 Compare April 21, 2025 10:17
@sunnylovestiramisu
Copy link

LGTM of the sig-storage Windows fix for golang 1.23

@npolshakova
Copy link
Contributor

Looks good! 🎉 We can do any additional fixes as follow-ups.

/lgtm
/approved
/hold

Remove hold when ready @rayandas

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2025
@rayandas
Copy link
Member Author

Can merge now.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, rayandas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit b92119e into kubernetes:master Apr 21, 2025
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Apr 21, 2025
@rayandas rayandas deleted the 1.33-final-release-note-draft branch April 21, 2025 19:56
@rayandas
Copy link
Member Author

We have merged this PR. if you have any more suggestions, please add it to the new PR: #2769 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants