Skip to content

KEP 4818: PodLifecycleSleepActionAllowZero beta graduation #49858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

KEP 4818: PodLifecycleSleepActionAllowZero beta graduation #49858

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9b317
Docs PR for KEP 4818: Pod Lifecycle Sleep action allow zero value
sreeram-venkitesh Feb 21, 2025
e414aeb
Update container-lifecycle-hooks.md
tengqm Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/concepts/containers/container-lifecycle-hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Resources consumed by the command are counted against the Container.
This is a beta-level feature default enabled by the `PodLifecycleSleepAction` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/).
Copy link
Contributor

@sftim sftim Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? Do we still need the note callout block / can we simplify?

Copy link
Member Author

@sreeram-venkitesh sreeram-venkitesh Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature gate would be enabled by default. We can remove the callout if that makes sense and mention that Sleep action supports a value of zero from v1.33. I guess this would be okay since sleep action also is at beta stage right now and is not graduating to GA in v1.33.

Copy link
Member Author

@sreeram-venkitesh sreeram-venkitesh Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the comment initially. The PodLifecycleSleepAction feature gate is still in beta. Since both PodLifecycleSleepAction and PodLifecycleSleepActionAllowZero feature gates are in beta and enabled by default, we can possibly simplify the callout block. Shall I add the line about the zero value in along with the description for sleep in line 59?


{{< note >}}
Enable the `PodLifecycleSleepActionAllowZero` feature gate if you want to set a sleep duration of zero seconds (effectively a no-op) for your Sleep lifecycle hooks.
The beta level `PodLifecycleSleepActionAllowZero` feature gate which is enabled by default from v1.33 allows you to set a sleep duration of zero seconds (effectively a no-op) for your Sleep lifecycle hooks.
{{< /note >}}

### Hook handler execution
Expand Down
4 changes: 4 additions & 0 deletions .../command-line-tools-reference/feature-gates/PodLifecycleSleepActionAllowZero.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@ stages:
- stage: alpha
defaultValue: false
fromVersion: "1.32"
toVersion: "1.32"
- stage: beta
defaultValue: true
fromVersion: "1.33"
---
Enables setting zero value for the `sleep` action in [container lifecycle hooks](/docs/concepts/containers/container-lifecycle-hooks/).