Skip to content

KEP 4818: PodLifecycleSleepActionAllowZero beta graduation #49858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

KEP 4818: PodLifecycleSleepActionAllowZero beta graduation #49858

merged 2 commits into from
Apr 5, 2025

Conversation

@sreeram-venkitesh
Copy link
Member

@sreeram-venkitesh sreeram-venkitesh commented Feb 21, 2025

Description

Docs changes for KEP 4818: Allow zero value for Sleep Action of PreStop Hook beta graduation.

Related PRs

Issue

Closes: nil, part of kubernetes/enhancements#4818

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2025
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Feb 21, 2025
Closed
14 tasks
@netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e414aeb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f0d3e8aa2e9600085b66d1

@netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit e414aeb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f0d3e8bcce780008f48f49
😎 Deploy Preview https://deploy-preview-49858--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Feb 23, 2025

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 23, 2025
sftim
sftim reviewed Feb 23, 2025
View reviewed changes
content/en/docs/concepts/containers/container-lifecycle-hooks.md Outdated
Resources consumed by the command are counted against the Container.
* HTTP - Executes an HTTP request against a specific endpoint on the Container.
* Sleep - Pauses the container for a specified duration.
This is a beta-level feature default enabled by the `PodLifecycleSleepAction` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/).
Copy link
Contributor

@sftim sftim Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? Do we still need the note callout block / can we simplify?

Copy link
Member Author

@sreeram-venkitesh sreeram-venkitesh Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature gate would be enabled by default. We can remove the callout if that makes sense and mention that Sleep action supports a value of zero from v1.33. I guess this would be okay since sleep action also is at beta stage right now and is not graduating to GA in v1.33.

Copy link
Member Author

@sreeram-venkitesh sreeram-venkitesh Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the comment initially. The PodLifecycleSleepAction feature gate is still in beta. Since both PodLifecycleSleepAction and PodLifecycleSleepActionAllowZero feature gates are in beta and enabled by default, we can possibly simplify the callout block. Shall I add the line about the zero value in along with the description for sleep in line 59?

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node: code and documentation PRs Feb 27, 2025
@Urvashi0109
Copy link
Contributor

Urvashi0109 commented Apr 3, 2025

Hello @sreeram-venkitesh, 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@haircommander
Copy link
Contributor

haircommander commented Apr 4, 2025

/lgtm

from sig node

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 4, 2025

LGTM label has been added.

Git tree hash: 71e81635377de29beed1c76f48dc2dbc5fa253c6

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2025
@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

/approve

@tengqm tengqm added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2025
@haircommander
Copy link
Contributor

haircommander commented Apr 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

LGTM label has been added.

Git tree hash: 548392ee1a68c9c264f4b39afbeb8ad211932990

@k8s-ci-robot k8s-ci-robot merged commit cf40ef0 into kubernetes:dev-1.33 Apr 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Reviewer to Done in SIG Node: code and documentation PRs Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@thockin thockin Awaiting requested review from thockin

@haircommander haircommander Awaiting requested review from haircommander

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sreeram-venkitesh @sftim @Urvashi0109 @haircommander @k8s-ci-robot @tengqm