Update the description of TopologySpreadConstraints's matchLabelKeys to align with the design change #49607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
sanposhiho
reviewed
Jan 31, 2025
content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
Member
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Jan 31, 2025
Contributor
sftim
left a comment
sftim
left a comment
There was a problem hiding this comment.
My main feedback here is not to use a warning callout, as warning is too prominent.
content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
sftim
reviewed
Feb 1, 2025
| A null or empty list means only match against the `labelSelector`. | ||
|
|
||
| {{< caution >}} | ||
| It's not recommended to use `matchLabelKeys` with labels that might be updated directly on pods. |
Contributor
There was a problem hiding this comment.
Slightly better: The Kubernetes project recommends against using…
(because we favor the active voice)
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 42a82068fa8e633bf5b8cce31dda86d5c2041a1e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the description of TopologySpreadConstraints's
matchLabelKeysto align with the design change by kubernetes/kubernetes#129874.This also includes the deprecation notice related to
matchLabelKeys.related: