Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys #49602

mochizuki875 · 2025-01-31T05:24:20Z

Description

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys.

KEP-3633 Introduce MatchLabelKeys and MismatchLabelKeys to PodAffinity and PodAntiAffinity
KEP-3243 he update to labels specified at matchLabelKeys isn't supported
matchLabelKeys in PodTopologySpread should insert a labelSelector like PodAffinity's matchLabelKeys kubernetes#129480 (comment)

Special notes for your reviewer

This notification was found when we discussed about PodTopologySpread's matchLabelKeys.(#129480)
But the same can be applied to PodAffinity's matchLabelKeys/mismatchLabelKeys.

netlify · 2025-01-31T05:33:48Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`aad1b7c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679e5944bfd8f6000849bfbc
😎 Deploy Preview	https://deploy-preview-49602--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sanposhiho

You should:

change this PR to only include the mention for PodAffinity.
create another PR for PodTopologySpread for dev-1.33 branch so that this wouldn't be reflected onto the website until 1.33 is released.

sanposhiho · 2025-01-31T05:49:42Z

/sig scheduling

sanposhiho · 2025-01-31T05:49:49Z

/cc @macsko @dom4ha

mochizuki875 · 2025-01-31T06:40:47Z

change this PR to only include the mention for PodAffinity.

I've done.

create another PR for PodTopologySpread for dev-1.33 branch so that this wouldn't be reflected onto the website until 1.33 is released.

I'll submit another PR for PodTopologySpread.

macsko · 2025-01-31T08:30:24Z

/lgtm

k8s-ci-robot · 2025-01-31T08:30:31Z

LGTM label has been added.

Details

Git tree hash: 827337839dc5abb8cbe2df30f1aace2982410acb

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md

mochizuki875 · 2025-01-31T12:50:17Z

I've changed warning callout to caution according to #49607 (review).

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md

sanposhiho · 2025-01-31T22:02:00Z

/cc @sftim

sftim · 2025-02-01T22:27:24Z

Once this PR has been reviewed and has the lgtm label, please assign sftim for approval.

No LGTM yet. Happy for other reviews to happen.
/uncc

sanposhiho

/lgtm

k8s-ci-robot · 2025-02-02T14:45:35Z

LGTM label has been added.

Details

Git tree hash: e422fbdfd1b9473ff6c20e9481cec35c7625dd0d

sanposhiho · 2025-02-02T14:45:50Z

/cc @sftim

sftim

/approve

sftim · 2025-02-16T17:18:28Z

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md


+{{< caution >}}
+It's not recommended to use `matchLabelKeys` with labels that might be updated directly on pods.
+Even if you edit the pod's label that is specified at `matchLabelKeys` **directly**, (that is, not via a deployment),


nit: Deployment should have a capital D; also, we have more than one API for workload management (eg StatefulSet is a thing).

sftim · 2025-02-16T17:18:31Z

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md


+{{< caution >}}
+It's not recommended to use `mismatchLabelKeys` with labels that might be updated directly on pods.
+Even if you edit the pod's label that is specified at `mismatchLabelKeys` **directly**, (that is, not via a deployment),


nit: Deployment should have a capital D; also, we have more than one API for workload management (eg StatefulSet is a thing).

k8s-ci-robot · 2025-02-16T17:18:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 31, 2025

k8s-ci-robot requested review from davidopp and reylejano January 31, 2025 05:24

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025

mochizuki875 mentioned this pull request Jan 31, 2025

Change the implementation design of matchLabelKeys in PodTopologySpread to be aligned with PodAffinity kubernetes/kubernetes#129874

Merged

sanposhiho reviewed Jan 31, 2025

View reviewed changes

k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 31, 2025

k8s-ci-robot requested review from dom4ha and macsko January 31, 2025 05:49

Add deprecation notices related to matchLabelKeys/mismatchLabelKeys

14bd4e5

mochizuki875 force-pushed the add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys branch from 537caae to 14bd4e5 Compare January 31, 2025 06:32

mochizuki875 changed the title ~~Add deprecation notices related to matchLabelKeys/mismatchLabelKeys~~ Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys Jan 31, 2025

k8s-ci-robot assigned macsko Jan 31, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025

sanposhiho reviewed Jan 31, 2025

View reviewed changes

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md Show resolved Hide resolved

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved

fix1

8f470ed

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025

fix2

4e3a60a

sanposhiho reviewed Jan 31, 2025

View reviewed changes

content/en/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved

k8s-ci-robot requested a review from sftim January 31, 2025 22:02

fix3

aad1b7c

mochizuki875 force-pushed the add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys branch from 7550bfb to aad1b7c Compare February 1, 2025 17:26

k8s-ci-robot removed the request for review from sftim February 1, 2025 22:27

sanposhiho reviewed Feb 2, 2025

View reviewed changes

k8s-ci-robot assigned sanposhiho Feb 2, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2025

k8s-ci-robot requested a review from sftim February 2, 2025 14:45

sftim reviewed Feb 16, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2025

k8s-ci-robot merged commit 4762f58 into kubernetes:main Feb 16, 2025
6 checks passed

windsonsea mentioned this pull request Feb 17, 2025

[zh] Sync assign-pod-node.md #49802

Merged

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys #49602

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys #49602

Uh oh!

Conversation

mochizuki875 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Special notes for your reviewer

Uh oh!

netlify bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

sanposhiho left a comment

Choose a reason for hiding this comment

Uh oh!

sanposhiho commented Jan 31, 2025

Uh oh!

sanposhiho commented Jan 31, 2025

Uh oh!

mochizuki875 commented Jan 31, 2025

Uh oh!

macsko commented Jan 31, 2025

Uh oh!

k8s-ci-robot commented Jan 31, 2025

Uh oh!

Uh oh!

Uh oh!

mochizuki875 commented Jan 31, 2025

Uh oh!

Uh oh!

sanposhiho commented Jan 31, 2025

Uh oh!

sftim commented Feb 1, 2025

Uh oh!

sanposhiho left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 2, 2025

Uh oh!

sanposhiho commented Feb 2, 2025

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

sftim Feb 16, 2025

Choose a reason for hiding this comment

Uh oh!

sftim Feb 16, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mochizuki875 commented Jan 31, 2025 •

edited

Loading

netlify bot commented Jan 31, 2025 •

edited

Loading