Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: topologymgr: docs: Kubelet Topology Manager graduation to GA #40044

Merged
merged 2 commits into from
Apr 7, 2023
Merged

node: topologymgr: docs: Kubelet Topology Manager graduation to GA #40044

merged 2 commits into from
Apr 7, 2023

Conversation

swatisehgal
Copy link
Contributor

Docs update for Kubelet Topology Manager graduation to GA.
Issue: kubernetes/enhancements#693 (comment)

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@swatisehgal swatisehgal mentioned this pull request Mar 16, 2023
Closed
11 tasks
@swatisehgal swatisehgal force-pushed the topologymgr-ga-graduation-1.27 branch from f321920 to 63112de Compare March 23, 2023 05:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2023
@swatisehgal swatisehgal force-pushed the topologymgr-ga-graduation-1.27 branch from 63112de to 894b774 Compare March 28, 2023 08:33
@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit de90c02
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642f6d342492f30008eb4c33

@mickeyboxell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8738898e1333d64592da06450877931e31cc555c

tengqm
tengqm reviewed Mar 31, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
Comment on lines 719 to 720
Topology Manager graduated to GA in 1.27 and is enabled by default. If you are using a version of
Kubernetes older than v1.27, switch to the documentation for that version of Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This two lines can be safely dropped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swatisehgal Please drop the two lines when you have a moment and we can merge this PR.

@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-node-pr-reviews : PTAL for a tech sign-off.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 5, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2023

@swatisehgal Mind give this another stab?

sftim
sftim reviewed Apr 5, 2023
View reviewed changes
content/en/docs/tasks/administer-cluster/topology-manager.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (doesn't block merge)

For GA, we prefer to follow the style guide. For example, headings within the text should be in sentence case.

@bart0sh
Copy link
Contributor

bart0sh commented Apr 6, 2023

/lgtm
/assign @mrunalp @derekwaynecarr @dchen1107

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 7, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5bb5e256cfe536a3d85d7aabaf9093171102c9af

@tengqm
Copy link
Contributor

tengqm commented Apr 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4343803 into kubernetes:dev-1.27 Apr 7, 2023
@swatisehgal
Copy link
Contributor Author

@sftim @tengqm Thanks for reviewing this PR and driving it to conclusion in my absence due to being on holidays. I truly appreciate it!
I will address any pending non-blocking comments in a separate PR once we are back from Kubecon. Thanks again!

@swatisehgal swatisehgal deleted the topologymgr-ga-graduation-1.27 branch April 11, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@ConnorDoyle ConnorDoyle Awaiting requested review from ConnorDoyle

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@bart0sh bart0sh Awaiting requested review from bart0sh

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@tengqm tengqm

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@mickeyboxell mickeyboxell

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
10 participants
@swatisehgal @mickeyboxell @k8s-ci-robot @divya-mohan0209 @tengqm @bart0sh @sftim @mrunalp @derekwaynecarr @dchen1107