Skip to content

Conversation

@windsonsea
Copy link
Member

@windsonsea windsonsea commented Oct 20, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Oct 20, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 20, 2022 01:43
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 20, 2022
@netlify
Copy link

netlify bot commented Oct 20, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3f4b589
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/636765776f40760009566f52
😎 Deploy Preview https://deploy-preview-37397--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Nov 6, 2022

Sorry for the delay. Please also include #37364 and #37494 changes.

@windsonsea
Copy link
Member Author

Sorry for the delay. Please also include #37364 and #37494 changes.

Ok, synced with the new changes

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sea-n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2022
@Sea-n
Copy link
Member

Sea-n commented Nov 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 89b20e3b5401a486b945e0011224264237392580

@k8s-ci-robot k8s-ci-robot merged commit 8b8e834 into kubernetes:main Nov 6, 2022
@windsonsea windsonsea deleted the dnspod branch November 8, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants