Skip to content

Add DNS search domain list limits and remove resolved DNS issue #37364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 22, 2022
Merged

Add DNS search domain list limits and remove resolved DNS issue #37364

k8s-ci-robot merged 1 commit into from
Oct 22, 2022

Conversation

@gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Oct 18, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Oct 18, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2022
@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit a2b4c34
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/63514284b42f6b0009e79603

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2022
@gjkim42 gjkim42 mentioned this pull request Oct 18, 2022
Closed
12 tasks
@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from 3c1efb2 to 8dc9bac Compare October 18, 2022 14:08
thockin
thockin reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from me

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 18, 2022

LGTM label has been added.

Git tree hash: 476ebbffd5ae58980ff4563a4d0bcfb52fc3c08d

@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from 8dc9bac to c01ce00 Compare October 19, 2022 00:24
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 19, 2022

/assign @savitharaghunathan

@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from c01ce00 to 6eeeb8d Compare October 19, 2022 04:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
sftim
sftim reviewed Oct 19, 2022
View reviewed changes
content/en/docs/concepts/services-networking/dns-pod-service.md Outdated
Comment on lines 328 to 329
[Expanded DNS Configuration](https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2595-expanded-dns-config#notesconstraintscaveats-optional)
requires container runtime support.
Copy link
Contributor

@sftim sftim Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this more prominent than the feature gate detail, because the feature is enabled by default.

content/en/docs/concepts/services-networking/dns-pod-service.md Outdated
options ndots:5
```

#### Expanded DNS Configuration
Copy link
Contributor

@sftim sftim Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document the overall behavior, not the change (the new feature)

Suggested change
#### Expanded DNS Configuration
## DNS search domain list limits

@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from 6eeeb8d to a8fa7bc Compare October 20, 2022 11:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2022
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 20, 2022

/retitle Add DNS search domain list limits and remove resolved DNS issue

@k8s-ci-robot k8s-ci-robot changed the title Promote ExpandedDNSConfig feature to the beta stage Add DNS search domain list limits and remove resolved DNS issue Oct 20, 2022
@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from a8fa7bc to 0f7ce80 Compare October 20, 2022 12:01
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 20, 2022

@sftim

Updated the docs. Thanks for the review.

  • added DNS search domain list limits section
  • removed the resolved issue for this feature.

@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-beta branch from 0f7ce80 to a2b4c34 Compare October 20, 2022 12:43
thockin
thockin reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech OK

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 21, 2022

LGTM label has been added.

Git tree hash: d3d950101f2b4a593e7ca0c376acd85ce03c0522

@tengqm
Copy link
Contributor

tengqm commented Oct 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit d09f2c2 into kubernetes:dev-1.26 Oct 22, 2022
@gjkim42 gjkim42 deleted the promote-expanded-dns-config-to-beta branch October 22, 2022 01:58
@Sea-n Sea-n mentioned this pull request Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

+2 more reviewers

@thockin thockin thockin left review comments

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thockin thockin

@savitharaghunathan savitharaghunathan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

1.26

Development

Successfully merging this pull request may close these issues.

6 participants

@gjkim42 @k8s-ci-robot @tengqm @thockin @sftim @savitharaghunathan