Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubectl-convert plugin installation info #28740

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Add kubectl-convert plugin installation info #28740

merged 4 commits into from
Jul 12, 2021

Conversation

bhumijgupta
Copy link
Member

This PR adds information on how to install kubectl-convert plugin

Fixes #28724

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @bhumijgupta!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 1, 2021
@netlify
Copy link

netlify bot commented Jul 1, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 437e2a7

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60e2f0e727e6fa00085e69ec

😎 Browse the preview: https://deploy-preview-28740--kubernetes-io-main-staging.netlify.app

@shannonxtreme
Copy link
Contributor

What if you added the kubectl convert info under "Optional kubectl configurations" and changed that h2 to "Optional kubectl configurations and plugins"? That way, you can have an h3 called "Install the kubectl convert plugin" with a one or two sentence overview of what it is, a link to learn more, and the instructions to install/verify all in one place, repeated on each OS's page.

@bhumijgupta
Copy link
Member Author

@shannonxtreme that does sound great. I'll work to incorporate your suggestions

@shannonxtreme
Copy link
Contributor

kubectl convert is also mentioned here: https://kubernetes.io/docs/tasks/administer-cluster/cluster-upgrade/#update-manifests. Might be useful to add a link from that page to the main "Install Tools" page for folks looking to upgrade manifests.

@shannonxtreme
Copy link
Contributor

Thank you for your contributions :)

@bhumijgupta
Copy link
Member Author

kubectl convert is also mentioned here: kubernetes.io/docs/tasks/administer-cluster/cluster-upgrade/#update-manifests. Might be useful to add a link from that page to the main "Install Tools" page for folks looking to upgrade manifests.

Currently install tools page does not have a section for Install kubectl-convert plugin or something like that. And from the headings alone it won't be clear where the kubectl-convert installation instructions are.

@Scofield-Idehen
Copy link

Waiting patiently, i think 1.16 made it really more time consuming to Deplore, But finger crossed as to changes being made

@shannonxtreme
Copy link
Contributor

kubectl convert is also mentioned here: kubernetes.io/docs/tasks/administer-cluster/cluster-upgrade/#update-manifests. Might be useful to add a link from that page to the main "Install Tools" page for folks looking to upgrade manifests.

Currently install tools page does not have a section for Install kubectl-convert plugin or something like that. And from the headings alone it won't be clear where the kubectl-convert installation instructions are.

Valid point. Maybe for a future PR we can add something to the "Update Manifests" section like "To install the kubectl convert plugin on clusters with Kubernetes version 1.21 and later, find the instructions specific to your operating system on the Install Tools page"

Not a priority for this PR, I think.

@bhumijgupta
Copy link
Member Author

For the current scope, this PR is ready to be reviewed

cc @sftim

sftim
sftim reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback. I hope it all makes sense.

@bhumijgupta bhumijgupta requested a review from sftim July 5, 2021 15:06
@sftim
Copy link
Contributor

sftim commented Jul 8, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@mbevc1
Copy link

mbevc1 commented Jul 12, 2021

Nice one 👍 . Not a comment on this PR directly, but would be nice to have this binary part of kubectl Yum/Deb repos as well.

@sftim sftim mentioned this pull request Jul 12, 2021
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phyber, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phyber
Copy link

phyber commented Jul 12, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c4e982bdc22a2b966769dbb2f18b534edae051f

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 670116c into kubernetes:main Jul 12, 2021
@bhumijgupta bhumijgupta mentioned this pull request Sep 9, 2021
Closed
7 tasks
shannonxtreme added a commit to shannonxtreme/website that referenced this pull request Nov 11, 2021
@shannonxtreme
Add shannon to reviewers
5d480f0 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
@shannonxtreme shannonxtreme mentioned this pull request Nov 11, 2021
Merged
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
@shannonxtreme @trierra
Add shannon to reviewers
707fc2d 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
@shannonxtreme @trierra
Add shannon to reviewers
dcc64aa 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
@shannonxtreme @trierra
Add shannon to reviewers
c4ab0d0 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
@shannonxtreme @trierra
Add shannon to reviewers
548f71c 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
kevindelgado pushed a commit to kevindelgado/kubernetes.github.io that referenced this pull request Nov 17, 2021
@shannonxtreme @kevindelgado
Add shannon to reviewers
8b8b667 
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phyber phyber phyber approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@zparnold zparnold Awaiting requested review from zparnold

@sftim sftim Awaiting requested review from sftim

Assignees

@phyber phyber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to install kubectl convert plugin
7 participants
@bhumijgupta @k8s-ci-robot @shannonxtreme @Scofield-Idehen @sftim @mbevc1 @phyber