Create pod eviction concept topic #27739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c184f20 https://deploy-preview-27739--kubernetes-io-master-staging.netlify.app |
|
I agree that https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ doesn't really explain a task. We could actually redirect it to the new page if we don't replace it. |
sftim
reviewed
Apr 27, 2021
k8s-ci-robot
added
size/L
shannonxtreme
commented
Apr 27, 2021
|
I ported over content from the Out of Resource Handling topic (and made lots of edits to it). We can remove that topic entirely. Same for "Eviction Policy" - that content is now in Eviction.md. |
sftim
reviewed
Apr 27, 2021
|
@sftim I've reached out to |
|
/cc @dashpole @bobbypage |
dashpole
reviewed
Apr 27, 2021
shannonxtreme
commented
Apr 27, 2021
shannonxtreme
commented
Apr 27, 2021
There was a problem hiding this comment.
Implemented some of @dashpole's edits and added followups to others.
bobbypage
reviewed
Apr 27, 2021
sftim
reviewed
Apr 27, 2021
shannonxtreme
force-pushed
the
pod-eviction
branch
from
108a1fb
to
2e1ac21
Compare
dashpole
reviewed
Apr 28, 2021
dashpole
reviewed
Apr 28, 2021
shannonxtreme
force-pushed
the
pod-eviction
branch
from
cc4d451
to
c184f20
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 144a5aeeb93c9a85550516b0cea2307ad524f666
|
|
👀 |
|
@sftim what else do I need for approval on this one? |
|
If someone who's not me LGTMs this, I can approve it. |
|
@alculquicondor sorry, I pushed to implement your final comment and it removed your lgtm. Would you mind adding it again? Thanks! |
|
/lgtm still applies :) |
|
Let's do this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 20, 2021
Closed
6 tasks
shannonxtreme
added a commit
to shannonxtreme/website
that referenced
this pull request
Nov 11, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra
pushed a commit
to trierra/website
that referenced
this pull request
Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra
pushed a commit
to trierra/website
that referenced
this pull request
Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra
pushed a commit
to trierra/website
that referenced
this pull request
Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra
pushed a commit
to trierra/website
that referenced
this pull request
Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
kevindelgado
pushed a commit
to kevindelgado/kubernetes.github.io
that referenced
this pull request
Nov 17, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work for #14507
Created a new draft concept topic for Pod Eviction. Merged content from out-of-resource.md and eviction-policy.md.
Questions/comments
Closed issues
[Line 37] - the control plane, the scheduler, or "the control plane or kube-controller manager"?[Line 88-91] - What is the best way to describenodefsandimagefs? Related comment thread.[Line 96-100] - Has the kubelet deprecated garbage collection for eviction in DiskPressure conditions?[Line 245-251] - should we reword to make it clear that only the pods' cgroup is checked for memory eviction? Related commentVerify that the Known Issues list and any areas marked for "future deprecation" are still valid.https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ has many conceptual sections which I suggest we move to this topic. That task topic doesn't actually have any "tasks". We should consider adding instructions in that topic for actually configuring the parameters, and move the conceptual info to theEviction Parameterssection in this concept topic.Where does this topic belong? Scheduling and Eviction or Cluster Administration? Related discussion thread[Line 199-216] - does "garbage collect" replace "delete" in all four points?/sig docs
/language en
/do-not-merge work-in-progress
/assign @sftim