PR for adding ScaleIO PV documentation in volumes.md #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
23 tasks
|
@mikedanese Hi, any chance someone can take a look at this PR. Thanks. |
|
@vladimirvivien FYI we moved Volumes to /docs/concepts/storage/volumes.md, which is why there is a merge conflict. If you can apply your changes to the document in the new location, I can merge it after a tech review lgtm. |
chenopis
reviewed
Mar 22, 2017
docs/user-guide/volumes.md
Outdated
| ScaleIO is a software-based storage platform that can use existing hardware to create clusters of scalable | ||
| shared block networked storage. The ScaleIO volume plugin allows deployed pods to access existing ScaleIO | ||
| volumes (or it can dynamically provision new volumes for persistent volume claims, see | ||
| [ScaleIO Persistent Volumes](./persistent-volumes/index.md#scaleio)). |
There was a problem hiding this comment.
Since this document has moved, you'll probably want to use a less relative URL for the link:
/docs/user-guide/persistent-volumes/#scaleio
There was a problem hiding this comment.
@chenopis the doc has been moved to concepts/docs/storage and the relative links fixed. Looking for LGTM. Thanks.
|
@chenopis @mikedanese this PR is ready for review, looking for LGTM for merge. Thanks. |
|
Tech LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PV documentation to volumes.md for ScaleIO volumes. Documentation for PVCs were done in #2741.
This change is