Adds documentation for Dell EMC ScaleIO volume plugin #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
23 tasks
jsafrane
reviewed
Mar 9, 2017
| * `protectionDomain`: the name of the ScaleIO protection domain | ||
| * `storagePool`: the name of the volume storage pool | ||
| * `storageMode`: the way storage is provisioned (ThinProvisionned or ThickProvisionned) | ||
| * `secretRef`: name reference to a configuered Secret object |
There was a problem hiding this comment.
- In what namespace is the secret expected?
- What are expected keys and values of the secret? Please follow example e.g. from quobyte above.
There was a problem hiding this comment.
@jsafrane Hi, I updated the doc to address your comments about namespace values.
jsafrane
reviewed
Mar 9, 2017
| #### ScaleIO | ||
| ```yaml | ||
| kind: StorageClass | ||
| apiVersion: storage.k8s.io/v1beta1 |
There was a problem hiding this comment.
Please use storage.k8s.io/v1, I'm waiting for #2686 to get merged.
This commit updates the volumes documentation to include ScaleIO volume plugin information.
|
Thanks for the PR. |
|
@jsafrane thank for the review. |
|
@jsafrane is there anything else I need to do for this to get merged? Thanks. |
|
Someone from docs team should merge it, I do just technical review. To be honest, I don't understand why it's assigned to me. @chenopis, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the volumes documentation to include ScaleIO volume plugin information.
This change is