Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding initial EndpointSlice documentation #16018

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Adding initial EndpointSlice documentation #16018

merged 1 commit into from
Sep 9, 2019

Conversation

robscott
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

@robscott: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Adding docs for EndpointSlices as described in the KEP and tracked by the enhancement issue.

Associated PRs:

/milestone 1.16
/hold
/sig network

cc @simplytunde

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d6377bd

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d76866e0077f30008cabb84

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2019
@xiangpengzhao
Copy link
Contributor

/cc @freehan @thockin @wojtek-t

sftim
sftim reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Here's some feedback that I hope you find useful.

content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpointslice.md Outdated
topology.kubernetes.io/zone: us-west2-a
```

## Enabling Endpoint Slices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this to a new Task page, leaving the Concept page short and readable.

Copy link
Member Author

@robscott robscott Sep 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to a new task page, but I'm thinking that task page needs some work, seems fairly light/empty right now. Let me know if you have any ideas for how I could fill this out.

content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 28, 2019
sftim
sftim reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some more feedback; I hope it's helpful.

content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/endpointslice.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2019
@simplytunde
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@simplytunde
Copy link
Contributor

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@simplytunde
Copy link
Contributor

@robscott The deadline to get this merged is Monday Sep 9.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2019
@robscott
Copy link
Member Author

robscott commented Sep 9, 2019

@kbhawkey Thanks for all the help with this! I think it's ready for another review now if you've got time.

@jimangel
Copy link
Member

jimangel commented Sep 9, 2019

/lgtm
/approve

From my review, it appears this is good to go. @kbhawkey @sftim if there was anything pending that you saw and I missed. Let's open up an issue and track.

/cc @simplytunde

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0f59654 into kubernetes:dev-1.16 Sep 9, 2019
kbhawkey
kbhawkey reviewed Sep 9, 2019
View reviewed changes
content/en/docs/reference/glossary/endpoint-slice.md
<!--more-->

A scalable and extensible way to group network endpoints together. These can be
used as by {{< glossary_tooltip text="kube-proxy" term_id="kube-proxy" >}} to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: used as by kube-proxy?

kbhawkey
kbhawkey reviewed Sep 9, 2019
View reviewed changes
content/en/docs/concepts/services-networking/endpoint-slices.md
{{% capture overview %}}

{{< feature-state for_k8s_version="v1.16" state="alpha" >}}
{{< glossary_definition term_id="endpoint-slice" length="short" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do you need this glossary definition here?

kbhawkey
kbhawkey reviewed Sep 9, 2019
View reviewed changes
content/en/docs/tasks/administer-cluster/enabling-endpoint-slices.md
extensibility of network endpoints in your cluster.

### Feature availability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robscott, things look good.
nit: Do you need the section, Feature availability? The feature is alpha and you have several 1.16 labels already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Should be resolved by #16267

This was referenced Sep 9, 2019
Merged
Closed
@Colstuwjx Colstuwjx mentioned this pull request Feb 19, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@bprashanth bprashanth Awaiting requested review from bprashanth

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@freehan freehan Awaiting requested review from freehan

@thockin thockin Awaiting requested review from thockin

@simplytunde simplytunde Awaiting requested review from simplytunde

Assignees

@jimangel jimangel

@simplytunde simplytunde

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@robscott @k8s-ci-robot @k8sio-netlify-preview-bot @xiangpengzhao @simplytunde @sftim @kbhawkey @jimangel @wojtek-t