EndpointSlice Controller #81048
Merged
EndpointSlice Controller #81048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
Hi @robscott. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
area/apiserver
area/test
kind/api-change
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
freehan
added
priority/important-longterm
robscott
force-pushed
the
endpointslice-controller
branch
from
ca48e8a
to
d259a9b
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
k8s-ci-robot
added
do-not-merge/hold
|
/retest |
robscott
force-pushed
the
endpointslice-controller
branch
from
54c950b
to
fc94770
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
thockin
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
robscott
force-pushed
the
endpointslice-controller
branch
from
fc94770
to
f97c3aa
Compare
k8s-ci-robot
removed
the
lgtm
robscott
force-pushed
the
endpointslice-controller
branch
2 times, most recently
from
1fb8c6b
to
32201ce
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
…On Wed, Aug 28, 2019, 7:56 PM Kubernetes Prow Robot < ***@***.***> wrote:
@robscott <https://github.com/robscott>: The following tests *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-verify 1fb8c6b
<1fb8c6b>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81048/pull-kubernetes-verify/1166878871010676738> /test
pull-kubernetes-verify
pull-kubernetes-bazel-test 32201ce
<32201ce>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81048/pull-kubernetes-bazel-test/1166904660376686592> /test
pull-kubernetes-bazel-test
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=81048>. Your
PR dashboard <https://gubernator.k8s.io/pr/robscott>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81048?email_source=notifications&email_token=ABKWAVHIEURCEAGZVZ4O5ZDQG43ERA5CNFSM4IJ2XMKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5NB7HQ#issuecomment-526000030>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKWAVB27B73DVUGZU5E3OLQG43ERANCNFSM4IJ2XMKA>
.
|
robscott
force-pushed
the
endpointslice-controller
branch
from
32201ce
to
75f6c24
Compare
|
/test pull-kubernetes-bazel-test |
|
/lgtm Why is this held? |
k8s-ci-robot
added
the
lgtm
|
Initially was trying to get a bit more into this PR but decided to pull that out into another one, then had to rebase on dual stack changes. Should have that other PR ready soon. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds an EndpointSlice Controller for the new Discovery API Group, building on the earlier PR here: #80766.
Special notes for your reviewer:
Until the PR this is built on gets merged in, the diff specific to this PR can be found here: robscott/kubernetes@discovery-api...robscott:endpointslice-controller
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: