storage: CSI inline volumes in beta #15705
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1316,6 +1316,7 @@ Learn how to | |
| #### CSI ephemeral volumes | ||
|
|
||
| {{< feature-state for_k8s_version="v1.15" state="alpha" >}} | ||
| {{< feature-state for_k8s_version="v1.16" state="beta" >}} | ||
|
|
||
| This feature allows CSI volumes to be directly embedded in the Pod specification instead of a PersistentVolume. Volumes specified in this way are ephemeral and do not persist across Pod restarts. | ||
|
|
||
|
|
@@ -1342,7 +1343,9 @@ spec: | |
| foo: bar | ||
| ``` | ||
|
|
||
| This feature requires CSIInlineVolume feature gate to be enabled. It | ||
| is enabled by default in Kubernetes >= 1.16. In Kubernetes v1.15, it | ||
|
There was a problem hiding this comment. @pohly , is line 1346 required, as the default is enabled for v1.16? There was a problem hiding this comment. Personally I prefer to keep the information about older releases if it doesn't get too long, because then users don't need to run a mental diff against older documentation to figure out the history. Some people have to work with more than just one release of Kubernetes, so that history is relevant. That this feature gate exists is also relevant, regardless of the history and whether its enabled or disabled by default. There was a problem hiding this comment. I assume future releases of the documentation will still have that paragraph. With that in mind I changed the second sentence to "It is enabled by default starting with Kubernetes 1.16.". The alternative, "It is enabled by default in Kubernetes 1.16", would look weird in documentation for Kubernetes 1.17... There was a problem hiding this comment. @pohly Thanks for jumping on this. Looks like the change you mentioned It is enabled by default starting with Kubernetes 1.16 is not yet in the doc. There was a problem hiding this comment. Oh, sorry, forgot the final |
||
| has to be enabled explicitly: | ||
|
|
||
| ``` | ||
| --feature-gates=CSIInlineVolume=true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You could remove line 1318 as the feature is now beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: I find history important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pohly They can always reference
command-line-tools-reference/feature-gates.mdfor 1.15 state.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @pohly. The best place to record the state and history of a feature/feature gate is the feature gates reference page. If needed, you could link to the reference page. I think the
feature-stateshortcode is typically used to label the current state of the feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The k8s.io site has a toggle for release (or 1.14, 1.15, etc) right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the line for alpha in 1.15.