storage: CSI inline volumes in beta #15705

pohly · 2019-08-06T19:20:53Z

Kubernetes 1.16 graduates this feature to beta.

Related-to: #14704,
kubernetes/enhancements#596

pohly · 2019-08-06T19:22:17Z

/hold

The feature has not been promoted to beta yet.

netlify · 2019-08-06T19:28:58Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 23be7aa

https://deploy-preview-15705--kubernetes-io-master-staging.netlify.com

zacharysarah · 2019-08-07T00:11:33Z

@pohly 👋 Please change the base from master to dev-1.16.

/milestone 1.16

msau42 · 2019-08-29T18:18:01Z

/lgtm

pohly · 2019-08-29T18:19:41Z

/hold cancel

kubernetes/kubernetes#82004 has been merged.

I also changed the base to dev-1.16. Do I also have to change master?

msau42 · 2019-08-29T18:27:42Z

You should not need to update master

kbhawkey · 2019-09-05T18:59:35Z

content/en/docs/concepts/storage/volumes.md

@@ -1342,7 +1343,9 @@ spec:
              foo: bar
 ```

-This feature requires CSIInlineVolume feature gate to be enabled:
+This feature requires CSIInlineVolume feature gate to be enabled. It
+is enabled by default in Kubernetes >= 1.16. In Kubernetes v1.15, it


@pohly , is line 1346 required, as the default is enabled for v1.16?

Personally I prefer to keep the information about older releases if it doesn't get too long, because then users don't need to run a mental diff against older documentation to figure out the history. Some people have to work with more than just one release of Kubernetes, so that history is relevant.

That this feature gate exists is also relevant, regardless of the history and whether its enabled or disabled by default.

@pohly I agree with @kbhawkey on this. Saying "It
is enabled by default in Kubernetes >= 1.16" already explains it is not enabled by default in previous releases.

I assume future releases of the documentation will still have that paragraph. With that in mind I changed the second sentence to "It is enabled by default starting with Kubernetes 1.16.".

The alternative, "It is enabled by default in Kubernetes 1.16", would look weird in documentation for Kubernetes 1.17...

@pohly Thanks for jumping on this. Looks like the change you mentioned It is enabled by default starting with Kubernetes 1.16 is not yet in the doc.

Oh, sorry, forgot the final git push. It's there now.

kbhawkey · 2019-09-05T19:03:00Z

Page previews:
https://deploy-preview-15705--kubernetes-io-master-staging.netlify.com/docs/concepts/storage/volumes/

https://deploy-preview-15705--kubernetes-io-master-staging.netlify.com/docs/reference/command-line-tools-reference/feature-gates/

kbhawkey · 2019-09-05T19:03:49Z

content/en/docs/concepts/storage/volumes.md

@@ -1316,6 +1316,7 @@ Learn how to
 #### CSI ephemeral volumes

 {{< feature-state for_k8s_version="v1.15" state="alpha" >}}
+{{< feature-state for_k8s_version="v1.16" state="beta" >}}


nit: You could remove line 1318 as the feature is now beta.

Same here: I find history important.

@pohly They can always reference command-line-tools-reference/feature-gates.md for 1.15 state.

hello @pohly. The best place to record the state and history of a feature/feature gate is the feature gates reference page. If needed, you could link to the reference page. I think the feature-state shortcode is typically used to label the current state of the feature.

The k8s.io site has a toggle for release (or 1.14, 1.15, etc) right?

I removed the line for alpha in 1.15.

simplytunde · 2019-09-06T13:43:18Z

/lgtm

simplytunde · 2019-09-06T13:52:43Z

Once the 2 issues raised have been addressed, this can be merged.

simplytunde · 2019-09-07T17:05:19Z

@pohly This PR is deadline for merging is Sep 9.

As pointed out during review, this information is better captured in the feature gates reference page.

pohly · 2019-09-09T06:17:40Z

@simplytunde: please have another look, I updated the PR.

k8sio-netlify-preview-bot · 2019-09-09T14:21:31Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 5db933e

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d765fe7859f1e0008e8aa37

simplytunde · 2019-09-09T14:52:30Z

Awesome @pohly . Thanks for all your work.
/lgtm

simplytunde · 2019-09-09T14:52:38Z

/approve

k8s-ci-robot · 2019-09-09T14:53:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [simplytunde]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

storage: CSI inline volumes in beta

23be7aa

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2019

pohly mentioned this pull request Aug 6, 2019

CSI Inline Volume Support kubernetes/enhancements#596

Closed

k8s-ci-robot requested review from Rajakavitha1 and thockin August 6, 2019 19:24

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 6, 2019

k8s-ci-robot added this to the 1.16 milestone Aug 7, 2019

pohly changed the base branch from master to dev-1.16 August 29, 2019 18:17

k8s-ci-robot assigned msau42 Aug 29, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019

pohly changed the title ~~WIP: storage: CSI inline volumes in beta~~ storage: CSI inline volumes in beta Aug 29, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019

kbhawkey reviewed Sep 5, 2019

View reviewed changes

k8s-ci-robot assigned simplytunde Sep 6, 2019

storage: remove historic information for CSI inline volumes

5db933e

As pointed out during review, this information is better captured in the feature gates reference page.

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2019

k8s-ci-robot merged commit 5b2906c into kubernetes:dev-1.16 Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: CSI inline volumes in beta #15705

storage: CSI inline volumes in beta #15705

pohly commented Aug 6, 2019 •

edited

Loading

pohly commented Aug 6, 2019

netlify bot commented Aug 6, 2019

zacharysarah commented Aug 7, 2019

msau42 commented Aug 29, 2019

pohly commented Aug 29, 2019

msau42 commented Aug 29, 2019

kbhawkey Sep 5, 2019

pohly Sep 6, 2019

simplytunde Sep 6, 2019

pohly Sep 9, 2019

simplytunde Sep 9, 2019

pohly Sep 9, 2019

kbhawkey commented Sep 5, 2019

kbhawkey Sep 5, 2019

pohly Sep 6, 2019

simplytunde Sep 6, 2019

kbhawkey Sep 6, 2019

msau42 Sep 6, 2019

kbhawkey Sep 6, 2019

pohly Sep 9, 2019 •

edited

Loading

simplytunde commented Sep 6, 2019

simplytunde commented Sep 6, 2019

simplytunde commented Sep 7, 2019

pohly commented Sep 9, 2019

k8sio-netlify-preview-bot commented Sep 9, 2019

simplytunde commented Sep 9, 2019

simplytunde commented Sep 9, 2019

k8s-ci-robot commented Sep 9, 2019

storage: CSI inline volumes in beta #15705

storage: CSI inline volumes in beta #15705

Conversation

pohly commented Aug 6, 2019 • edited Loading

pohly commented Aug 6, 2019

netlify bot commented Aug 6, 2019

zacharysarah commented Aug 7, 2019

msau42 commented Aug 29, 2019

pohly commented Aug 29, 2019

msau42 commented Aug 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbhawkey commented Sep 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pohly Sep 9, 2019 • edited Loading

Choose a reason for hiding this comment

simplytunde commented Sep 6, 2019

simplytunde commented Sep 6, 2019

simplytunde commented Sep 7, 2019

pohly commented Sep 9, 2019

k8sio-netlify-preview-bot commented Sep 9, 2019

simplytunde commented Sep 9, 2019

simplytunde commented Sep 9, 2019

k8s-ci-robot commented Sep 9, 2019

pohly commented Aug 6, 2019 •

edited

Loading

pohly Sep 9, 2019 •

edited

Loading