Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid pod phases #13840

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

Joseph-Irving
Copy link
Member

@Joseph-Irving Joseph-Irving commented Apr 16, 2019

Completed and CrashLoopBackOff are incorrectly listed as being a valid Pod Phase, these are container state reasons, not pod phases. Valid pod phases can be found here: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L2160.

This can cause some confusion e.g kubernetes/kubernetes#76619

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 16, 2019
@netlify
Copy link

netlify bot commented Apr 16, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 689dade

https://deploy-preview-13840--kubernetes-io-master-staging.netlify.com

@rajeshdeshpande02
Copy link
Contributor

/lgtm

Document should have valid pod phases but question comes when people see Completed , CrashLoopBackOff , ImagePullBackOff etc in STATUS column when we fire kubectl get pods command. So this need fix from product side. I also raised defect for this few days back: kubernetes/kubernetes#73685

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@tengqm
Copy link
Contributor

tengqm commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2eac42a into kubernetes:master Apr 19, 2019
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants