Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing pod status in pod lifecycle docs #12397

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Added missing pod status in pod lifecycle docs #12397

merged 2 commits into from
Jan 31, 2019

Conversation

makoscafee
Copy link
Contributor

Added information about completed and CrashLoopBackOff

@makoscafee
Added missing pod status in pod lifecycle docs
ee26390 
Added information about `completed` and `CrashLoopBackOff`
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2019
@makoscafee
Copy link
Contributor Author

This is for this issue #12389

@cody-clark
Copy link
Contributor

Hi @makoscafee! This looks great. Thanks for contributing!

Preview: https://deploy-preview-12397--kubernetes-io-master-staging.netlify.com/docs/concepts/workloads/pods/pod-lifecycle/

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2e0287d into kubernetes:master Jan 31, 2019
@makoscafee makoscafee mentioned this pull request Feb 1, 2019
Closed
2 tasks
@makoscafee makoscafee deleted the pod-status-docs branch February 12, 2019 07:07
@makoscafee makoscafee mentioned this pull request Mar 17, 2019
Closed
6 tasks
@sftim
Copy link
Contributor

sftim commented Apr 18, 2019 •
edited
Loading

#13840 points out that these are container state reasons, not pod phases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@cody-clark cody-clark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makoscafee @cody-clark @k8s-ci-robot @sftim